Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: hotfix release v12.0.3 #1617

Closed
wants to merge 10 commits into from
Closed

chore: hotfix release v12.0.3 #1617

wants to merge 10 commits into from

Conversation

brewmaster012
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

lumtis and others added 7 commits January 19, 2024 11:43
@lumtis @ws4charlie
refactor(hotfix): support retrying sending inbound vote with higher…
6de5bc8 
… gas limit (#1601)

* chore: v12.0.0 changelog (#1578)

* fix: skip unsupported chain parameters (#1581)

Co-authored-by: Lucas Bertrand <[email protected]>

* remove debug zetaclient1

* remove comments

* tx resend

* complete renaming

* change log level and create constants

* increase retry value

* test change gas limit for outbound

* refactor vote inbound outbound into separate files

* add monitoring capability for outbound txs

* changelog

---------

Co-authored-by: Charlie Chen <[email protected]>
@ws4charlie
fix: some necessary code refactor for banned address and bug fix duri…
d61e71d 
…ng refactor (#1603)
@brewmaster012
fix crash due to out of bound
b7825d4
@brewmaster012
use GetLastBlockHeightScanned() instead
a430a73
@ws4charlie @brewmaster012
cherry picked: fixed ChainParams equality check and added changelog e…
366e7e8 
…ntry
@brewmaster012
respect isSupported in zetaclient observation
5271d93
@brewmaster012
add some RPC diagnosis log
b0832e9
@brewmaster012 brewmaster012 changed the base branch from develop to v12.0.0 January 23, 2024 01:04
@github-actions GitHub Actions
Copy link

!!!WARNING!!!
nosec detected in the following files: zetaclient/bitcoin_client.go, zetaclient/broadcast.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Jan 23, 2024
@brewmaster012 brewmaster012 changed the base branch from v12.0.0 to v12.0.2 January 23, 2024 01:05
@lumtis lumtis closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingpinXD kingpinXD Awaiting requested review from kingpinXD kingpinXD is a code owner

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@lumtis lumtis Awaiting requested review from lumtis lumtis is a code owner

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

Assignees
No one assigned
Labels
breaking:cli nosec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brewmaster012 @lumtis @ws4charlie @kingpinXD