fix: some necessary code refactor for banned address and bug fix during refactor #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ws4charlie
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev and
lumtis
as code owners
ws4charlie
requested review from
brewmaster012
and removed request for
brewmaster012
|
Merging as it got 2 approvals previously |
10 tasks
lumtis
pushed a commit
that referenced
this pull request
Jan 24, 2024
lumtis
added a commit
that referenced
this pull request
Jan 25, 2024
* refactor(`hotfix`): support retrying sending inbound vote with higher gas limit (#1601) * chore: v12.0.0 changelog (#1578) * fix: skip unsupported chain parameters (#1581) Co-authored-by: Lucas Bertrand <[email protected]> * remove debug zetaclient1 * remove comments * tx resend * complete renaming * change log level and create constants * increase retry value * test change gas limit for outbound * refactor vote inbound outbound into separate files * add monitoring capability for outbound txs * changelog --------- Co-authored-by: Charlie Chen <[email protected]> * fix: some necessary code refactor for banned address and bug fix during refactor (#1603) * cherry picked: fixed ChainParams equality check and added changelog entry * respect isSupported in zetaclient observation * add some RPC diagnosis log * guard against multiple deposits * make cosmos go sec linter happy * update e2e tests * Update zetaclient/bitcoin_client.go Co-authored-by: Charlie Chen <[email protected]> --------- Co-authored-by: Charlie Chen <[email protected]> Co-authored-by: Charlie Chen <[email protected]> Co-authored-by: brewmaster012 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: 1592
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: