Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hotfix): support retrying sending inbound vote with higher gas limit #1601

Merged
merged 14 commits into from
Jan 19, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Jan 19, 2024

No description provided.

Copy link

!!!WARNING!!!
nosec detected in the following files: zetaclient/bitcoin_client.go, zetaclient/broadcast.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Jan 19, 2024
@lumtis lumtis changed the title hotfix: support retrying sending inbound vote with higher gas limit refactor(hotfix): support retrying sending inbound vote with higher gas limit Jan 19, 2024
@lumtis lumtis merged commit 6de5bc8 into v12.1.0-hotfix Jan 19, 2024
16 of 17 checks passed
@lumtis lumtis deleted the refactor/gas-limit branch January 19, 2024 19:43
lumtis added a commit that referenced this pull request Jan 24, 2024
… gas limit (#1601)

* chore: v12.0.0 changelog (#1578)

* fix: skip unsupported chain parameters (#1581)

Co-authored-by: Lucas Bertrand <[email protected]>

* remove debug zetaclient1

* remove comments

* tx resend

* complete renaming

* change log level and create constants

* increase retry value

* test change gas limit for outbound

* refactor vote inbound outbound into separate files

* add monitoring capability for outbound txs

* changelog

---------

Co-authored-by: Charlie Chen <[email protected]>
lumtis added a commit that referenced this pull request Jan 25, 2024
* refactor(`hotfix`): support retrying sending inbound vote with higher gas limit (#1601)

* chore: v12.0.0 changelog (#1578)

* fix: skip unsupported chain parameters (#1581)

Co-authored-by: Lucas Bertrand <[email protected]>

* remove debug zetaclient1

* remove comments

* tx resend

* complete renaming

* change log level and create constants

* increase retry value

* test change gas limit for outbound

* refactor vote inbound outbound into separate files

* add monitoring capability for outbound txs

* changelog

---------

Co-authored-by: Charlie Chen <[email protected]>

* fix: some necessary code refactor for banned address and bug fix during refactor (#1603)

* cherry picked: fixed ChainParams equality check and added changelog entry

* respect isSupported in zetaclient observation

* add some RPC diagnosis log

* guard against multiple deposits

* make cosmos go sec linter happy

* update e2e tests

* Update zetaclient/bitcoin_client.go

Co-authored-by: Charlie Chen <[email protected]>

---------

Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: brewmaster012 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants