Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update ledger dependencies #1590

Merged
merged 2 commits into from
Jan 17, 2024
Merged

chore: update ledger dependencies #1590

merged 2 commits into from
Jan 17, 2024

Conversation

CharlieMc0
Copy link
Member

Description

Updated the ledger dependencies so it works with the latest version of OSX 14.2.1.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

brewmaster012
brewmaster012 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@brewmaster012 brewmaster012 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it works now on macos 14 with zetacored CLI with Ledger Nano S.

@lumtis lumtis changed the title Updated ledger dependencies chore: update ledger dependencies Jan 17, 2024
@lumtis lumtis merged commit 84502dc into develop Jan 17, 2024
14 of 15 checks passed
@lumtis lumtis deleted the update-ledger-dependencies branch January 17, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@lumtis lumtis lumtis approved these changes

@kingpinXD kingpinXD Awaiting requested review from kingpinXD

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CharlieMc0 @lumtis @brewmaster012