Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: TSS and Hotkey password Prompt #1574

Closed
wants to merge 15 commits into from
Closed

feat: TSS and Hotkey password Prompt #1574

wants to merge 15 commits into from

Conversation

kevinssgh
Copy link
Contributor

Description

Partial implementation of password prompt for hotkey and tss keyshare files. The rest of the implementation will be in go-tss.

Closes: #1563

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@kevinssgh kevinssgh marked this pull request as draft January 12, 2024 18:51
@kevinssgh kevinssgh changed the title TSS and Hotkey password Prompt feat: TSS and Hotkey password Prompt Jan 12, 2024
@kevinssgh kevinssgh marked this pull request as ready for review January 15, 2024 20:21
lumtis
lumtis reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general for the local tests.
Need to be tested manually, if not done yet.

changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
cmd/zetaclientd/start.go Show resolved Hide resolved
contrib/localnet/scripts/start-zetaclientd-genesis.sh Show resolved Hide resolved
@kevinssgh kevinssgh changed the base branch from develop to v12.1.0-hotfix January 19, 2024 19:40
@kevinssgh kevinssgh requested review from lumtis and kingpinXD January 22, 2024 20:30
@lumtis
Copy link
Member

lumtis commented Jan 24, 2024

@kevinssgh can you target the PR back to develop?

@kevinssgh kevinssgh mentioned this pull request Jan 24, 2024
Merged
10 tasks
@kevinssgh
Copy link
Contributor Author

@kevinssgh can you target the PR back to develop?

Created new PR here since the branch has diverged a bit:

#1630

@lumtis
Copy link
Member

lumtis commented Jan 25, 2024

No longer relevant #1630

@lumtis lumtis closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis left review comments

@kingpinXD kingpinXD kingpinXD approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

Assignees
No one assigned
Labels
breaking:cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to use standard input for encryption password: TSS and HotKey
3 participants
@kevinssgh @lumtis @kingpinXD