Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosschain): add emptiness check for topic array in event parsing #1556

Merged
merged 3 commits into from
Jan 11, 2024
Merged

fix(crosschain): add emptiness check for topic array in event parsing #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef53471
add check for topic len
lumtis Jan 11, 2024
02e6c74
changelogs
lumtis Jan 11, 2024
6acffac
Merge branch 'develop' into fix/evmhook-check-log-len
lumtis Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
* [1525](https://github.com/zeta-chain/node/pull/1525) - relax EVM chain block header length check 1024->4096
* [1522](https://github.com/zeta-chain/node/pull/1522/files) - block `distribution` module account from receiving zeta
* [1528](https://github.com/zeta-chain/node/pull/1528) - fix panic caused on decoding malformed BTC addresses
* [1556](https://github.com/zeta-chain/node/pull/1556) - add emptiness check for topic array in event parsing
* [1555](https://github.com/zeta-chain/node/pull/1555) - Reduce websocket message limit to 10MB

### Refactoring
Expand Down
6 changes: 6 additions & 0 deletions x/crosschain/keeper/evm_hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,9 @@ func (k Keeper) ParseZRC20WithdrawalEvent(ctx sdk.Context, log ethtypes.Log) (*z
if err != nil {
return nil, err
}
if len(log.Topics) == 0 {
ws4charlie marked this conversation as resolved.
Show resolved Hide resolved
return nil, fmt.Errorf("ParseZRC20WithdrawalEvent: invalid log - no topics")
}
event, err := zrc20ZEVM.ParseWithdrawal(log)
if err != nil {
return nil, err
Expand Down Expand Up @@ -306,6 +309,9 @@ func ParseZetaSentEvent(log ethtypes.Log, connectorZEVM ethcommon.Address) (*con
if err != nil {
return nil, err
}
if len(log.Topics) == 0 {
ws4charlie marked this conversation as resolved.
Show resolved Hide resolved
return nil, fmt.Errorf("ParseZetaSentEvent: invalid log - no topics")
}
event, err := zetaConnectorZEVM.ParseZetaSent(log)
if err != nil {
return nil, err
Expand Down
Loading