Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax header length basic check #1525

Merged
merged 3 commits into from
Jan 9, 2024
Merged

fix: relax header length basic check #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0628be0
relax header length basic check
brewmaster012 Jan 4, 2024
3ba344d
update changelog
brewmaster012 Jan 4, 2024
c1d1cec
Merge branch 'develop' into fix-header-length-check
lumtis Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
* add check to verify new tss has been produced when triggering tss funds migration
* fix Athens-3 log print issue - avoid posting uncessary outtx confirmation
* fix docker build issues with version: golang:1.20-alpine3.18
* [1525](https://github.com/zeta-chain/node/pull/1525) - relax EVM chain block header length check 1024->4096
* [1522](https://github.com/zeta-chain/node/pull/1522/files) - block `distribution` module account from receiving zeta

### Refactoring
Expand Down
2 changes: 1 addition & 1 deletion common/headers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func (h HeaderData) Validate(blockHash []byte, chainID int64, height int64) erro
// validateEthereumHeader performs a basic validation of the Ethereum header
func validateEthereumHeader(headerBytes []byte, blockHash []byte, height int64) error {
// on ethereum the block header is ~538 bytes in RLP encoding
if len(headerBytes) > 1024 {
if len(headerBytes) > 4096 {
return fmt.Errorf("header too long (%d)", len(headerBytes))
}

Expand Down
Loading