Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the smoke test pipeline #1506

Closed
wants to merge 17 commits into from
Closed

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented Dec 27, 2023

Description

Updating to point to our new gcp runners to try and fix the smoke test issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This merge is to test.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@gzukel gzukel requested a review from a team as a code owner December 27, 2023 19:49
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Dec 27, 2023
@lumtis lumtis self-requested a review December 27, 2023 19:59
Comment on lines 123 to 124
echo "Sleep for 1 minute longer to let network start"
sleep 60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be necessary, the orchestrator already wait for the chain to start

@lumtis lumtis self-requested a review January 2, 2024 23:26
@lumtis
Copy link
Member

lumtis commented Jan 3, 2024

Closing it as the CI issue has been fixed

@lumtis lumtis closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants