fix: Stress test refactor #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinssgh
requested review from
brewmaster012,
kingpinXD,
fadeev,
lumtis and
ws4charlie
as code owners
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
lumtis
requested changes
Jan 17, 2024
contrib/localnet/orchestrator/smoketest/cmd/smoketest/stress.go
Outdated
Show resolved
Hide resolved
contrib/localnet/orchestrator/smoketest/cmd/smoketest/stress.go
Outdated
Show resolved
Hide resolved
contrib/localnet/orchestrator/smoketest/cmd/smoketest/stress.go
Outdated
Show resolved
Hide resolved
contrib/localnet/orchestrator/smoketest/cmd/smoketest/stress.go
Outdated
Show resolved
Hide resolved
contrib/localnet/orchestrator/smoketest/cmd/smoketest/stress.go
Outdated
Show resolved
Hide resolved
contrib/localnet/orchestrator/smoketest/cmd/smoketest/stress.go
Outdated
Show resolved
Hide resolved
contrib/localnet/orchestrator/smoketest/cmd/smoketest/stress.go
Outdated
Show resolved
Hide resolved
contrib/localnet/orchestrator/smoketest/cmd/smoketest/stress.go
Outdated
Show resolved
Hide resolved
The cmd should be able to do both, depending on the network flag. I mentioned in some of the comments that, it will be useful to make make sure the test is working correctly locally before attempting to run on an external network. This can save some time and effort if there are minor issues. |
|
@kevinssgh testing the command locally, is this normal logs? The tx number per min seems low to me |
Yes, locally it is much slower than the real network. You also have to remember this is outbound txn rate which takes some time based on the scheduler. |
lumtis
approved these changes
Jan 22, 2024
kingpinXD
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
It looks good to me ,
Curious though why are we using a withdraw only for the trees test , because the withdraw would be limited by the outbound TSS signing , which we already know .
Is the purpose only to add more transactions into the cosmos mempool ?
It might be a good idea to consider lowering the rate for withdraws and add some more transactions into the mix , we can create inbounds , or even bank sends back and forth between two accounts , which might be a more realistic simulation
The idea behind this stress test was to test the bottleneck in the network which is outbound withdraws. We can add more to this test in the future for sure as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled stress test cmd in smoketest
Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: