Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add monitoring(grafana, prometheus, ethbalance) for localnet testing #1498

Merged
merged 20 commits into from
Jan 10, 2024

Conversation

morde08
Copy link
Contributor

@morde08 morde08 commented Dec 22, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • [X ] Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link
Member

@CharlieMc0 CharlieMc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the performance problems with BlockScout is probably better to remove it from this PR and we can look into a more lightweight solution.

For the Pr title: it should be follow semantic PR format feat: add monitoring(grafana, prometheus, ethbalance) for localnet testing

The Grafana/monitoring work looks great. Just needs a small update the the README telling people how to access the interface locally and the default UN/PW

contrib/localnet/README.md Outdated Show resolved Hide resolved
@morde08 morde08 changed the title add monitoring(grafana, prometheus, ethbalance) and blockscout explorer for localnet testing feat: add monitoring(grafana, prometheus, ethbalance) for localnet testing Dec 28, 2023
@morde08 morde08 requested a review from a team as a code owner January 9, 2024 19:21
@morde08 morde08 merged commit 0fe3dc5 into zeta-chain:develop Jan 10, 2024
12 checks passed
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants