-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename aux.go => utils.go to avoid go package resolver complaint #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brewmaster012
requested review from
kingpinXD,
kevinssgh,
fadeev,
lumtis and
ws4charlie
as code owners
December 19, 2023 22:36
because of error importing this project ``` go: loading module retractions for github.com/zeta-chain/[email protected]: verifying go.mod: github.com/zeta-chain/[email protected]/go.mod: reading https://sum.golang.org/lookup/github.com/zeta-chain/[email protected]: 404 Not Found server response: not found: create zip: cmd/zetaclientd/aux.go: malformed file path "cmd/zetaclientd/aux.go": "aux" disallowed as path element component on Windows ```
brewmaster012
force-pushed
the
fix-aux-filename
branch
from
December 19, 2023 22:48
f6897d5
to
549dbc2
Compare
lumtis
reviewed
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not very conventional to end file with underscore. Can we maybe instead rename the file utils.go
?
lumtis
approved these changes
Dec 27, 2023
Co-authored-by: Lucas Bertrand <[email protected]>
brewmaster012
changed the title
fix: rename aux.go => aux_.go
fix: rename aux.go => utils.go to avoid go package resolver complaint
Dec 27, 2023
kingpinXD
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
because of error importing this project
Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: