Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v11.0.0 #1444

Merged
merged 23 commits into from
Dec 19, 2023
Merged

feat: v11.0.0 #1444

merged 23 commits into from
Dec 19, 2023

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented Dec 19, 2023

v11.0.0

Features

Fixes

Refactoring

Chores

Tests
Add unit tests for adding votes to a ballot

CI

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Release

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

kingpinXD and others added 23 commits November 10, 2023 17:23
@kingpinXD
feat: zeta supply checks (#1358)
aaadff9
@lumtis
chore: improve changelogs format (#1390)
5420527 
* sort changelogs

* refactor format

* comment
@lumtis
fix(crosschain): use event index in inbound tx digest (#1372)
5e635ca 
* add event index in observer inbound

* rename messages

* update method usage

* use event index

* fix cosmos-gosec

* depositor contract

* smoketest refactor

* fix contracts

* mutiple deposits smoke tests

* fix depositor

* withdrawer contract

* fix smoketest deposits

* fix withdrawer contract

* multiple withdraw test

* fix contracts

* fix withdraws

* update changelog
@ws4charlie @brewmaster012
fix: cherry pick v10.1.x hotfix (minRelayTxFee and bitcoin mainnet/te…
c66a904 
…stnet address format) (#1367)

* skip some more recent garbage outTx trackers

* skip garbage trackers and increase btc gas fee

* skip mainnet addresses in cctxs

* cherry picked minRelayTxFee hotfix and bitcoin testnet/mainnet address format fix

* resolve conflict

* update CHANGELOG.md for v10.1.x hotfix

---------

Co-authored-by: charliec <[email protected]>
Co-authored-by: brewmaster012 <[email protected]>
@kingpinXD
feat: update observer (#1384)
ce3cc5f
@CharlieMc0
chore: add chain id to localnet and open port 26657 to make local tes…
23c7d9a 
…ting easier. (#1401)

* added chain id to configs

* mapped port 26657 to localhost
@kevinssgh @lumtis
feat: Add HSM capability for zetaclient hot key - non production (#1387)
fd0e56e 
* initial commit

* Added sign function and unit test

* hsm config updates

* introduce hsm mode

* added commands to get address and generate key in hsm

* skipping unit test as it will fail in CI

* ran make generate and fixed lint errors

* Update cmd/zetaclientd/hsm.go

Co-authored-by: Lucas Bertrand <[email protected]>

* Update zetaclient/broadcast.go

Co-authored-by: Lucas Bertrand <[email protected]>

* Update zetaclient/broadcast.go

Co-authored-by: Lucas Bertrand <[email protected]>

* Update zetaclient/hsm_signer.go

Co-authored-by: Lucas Bertrand <[email protected]>

* Update zetaclient/hsm_signer.go

Co-authored-by: Lucas Bertrand <[email protected]>

* Update zetaclient/hsm_signer.go

Co-authored-by: Lucas Bertrand <[email protected]>

* cleanup

* added config for hsm hotkey name and moved hsm mode flag to zetabridge cfg

* add entry to changelog.

* moved hsm to new package and added build flag for unit test

* add changelog entry

* fix lint errors

---------

Co-authored-by: Lucas Bertrand <[email protected]>
@ws4charlie
fix: speed up evm outtx inclusion and improve log prints (#1406)
10308d1 
Co-authored-by: charliec <[email protected]>
@lumtis
docs: add code freeze note (#1414)
b98f760
@brewmaster012 @lumtis
zetaclient: allow one 1 event that remotely calls zEVM contract per tx
4d5995a
@brewmaster012 @lumtis
revert the accidental last commit
6d9e4c2
@ws4charlie @lumtis
include bitcoin outtx regardless of the cctx status (#38)
73d87a2
@kingpinXD @lumtis
refactor: condense logging for a supply checker (#9)
3f5fec9
@kingpinXD @lumtis
chore: increment handler version (#5)
ccfb7ed 
Co-authored-by: Lucas Bertrand <[email protected]>
@kingpinXD @lumtis
test: add tests for out tx tracker (#10)
8b765df 
* add tests fro out ts tracker

* use getEthereumChainID function in tests

---------

Co-authored-by: Lucas Bertrand <[email protected]>
@kevinssgh @lumtis
fix: Zellic-3.7 - Add check for existing contract address to avoid ov…
09eed9c 
…erwriting. (#13)

* add check for existing contract address to avoid overwriting.

* Added check for redeployment of gas and asset token contracts
Added unit test for this scenario

* update changelog

---------

Co-authored-by: Lucas Bertrand <[email protected]>
@lumtis @ws4charlie
fix: Zellic-3.2 - prevent deposit when zrc20 is paused (#31)
8130fef 
* add pause check

* revert on paused

* update tests

* add smoke test check

* goimports

* changelog

* Update x/crosschain/keeper/evm_deposit.go

Co-authored-by: Charlie Chen <[email protected]>

---------

Co-authored-by: Charlie Chen <[email protected]>
@kingpinXD @lumtis
test: ballot tests (#17)
b5409f4
@lumtis
refactor(fungible): use code hash in MsgUpdateContractBytecode to…
aa5fb62 
… allow for rollback (#23)

* code hash request

* make generate

* udpate message

* add cli command

* udpate smoke tests

* changelog

* update message name

* add check for length

* replace log with event

* add is contract check
@lumtis @kingpinXD
refactor: consolidate builds (#22)
dc5231e 
* remove begin block

* remove build from smoketest

* deploy system contracts message

* msg tx

* add system contract deployment in smoke tests

* start core params refactor

* changelog

* refactor chains

* config refactor

* remaining build tags

* lint issues

* lint issues 2

* gen docs

* gen docs 2

* gosec issues 1

* fix cosmos nosec

* lint issues

* fix core params check

* make generate

* fix assign

* use privnet chains by default

* fix chain fetching

* use local goerli for smoke tests

* remove unamed gosec

* address nosec

* other goerli net to rename in smoketests

* gosec

* nosec alerts

* nosec alert 2

* use Bitcoin specific network

* fix address system contracts

* add logs in test

* Add more logs

* test remaining smoke tests

* remove hardcoded ZetaChain chain ID

* remove bitcoin hardcoded values

* add back smoketests

* fix smoke test except cross chain swap

* make generate

* add log message

* fix evm swap contract

* fix unit test 1

* fix CLI tests

* make generate

* fix log error

* fix Bitcoin proof test

* fix address test

* remove network flag and improve smoke tests

* add admin group

* move core params out of genesis

* remove unnecessary RemoveInTxTrackerIfExists

* add check for contract failure

* Update x/crosschain/keeper/keeper_cross_chain_tx_vote_inbound_tx.go

Co-authored-by: Tanmay <[email protected]>

* fix install in action

* improve events for system contract deploy

* error handling for bitcoin net params

* add utility functions in common

* add stateful smoketest from source

* try test fix

* fix unit test

* fix tests

---------

Co-authored-by: Tanmay <[email protected]>
@lumtis
refactor: disable zeta supply checker routine (#45)
48b15c5
@lumtis
docs: update changelog with v11.0.0
f56eb84
@lumtis
chore: update go releaser
f6c1b92
@github-actions github-actions bot added ci Changes to CI pipeline or github actions breaking:proto breaking:cli labels Dec 19, 2023
@github-actions GitHub Actions
Copy link

!!!WARNING!!!
nosec detected in the following files: x/observer/client/cli/tx_update_observer.go, x/observer/keeper/msg_server_update_observer_test.go, contrib/localnet/orchestrator/smoketest/main.go, contrib/localnet/orchestrator/smoketest/test_accounting.go, contrib/localnet/orchestrator/smoketest/test_bitcoin.go, contrib/localnet/orchestrator/smoketest/test_deposit_eth.go, contrib/localnet/orchestrator/smoketest/test_stress.go, contrib/localnet/orchestrator/smoketest/test_update_bytecode.go, contrib/localnet/orchestrator/smoketest/test_zeta_in_and_out.go, contrib/rpctest/main.go, rpc/namespaces/ethereum/debug/api.go, rpc/namespaces/ethereum/debug/trace.go, rpc/namespaces/ethereum/debug/utils.go, rpc/websockets.go, server/start.go, testutil/network/util.go, x/crosschain/keeper/keeper_cross_chain_tx_vote_outbound_tx.go, x/observer/module_simulation.go, zetaclient/bitcoin_client.go, zetaclient/inbound_tracker.go, zetaclient/utils.go, zetaclient/config/config_chain.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Dec 19, 2023
CharlieMc0
CharlieMc0 previously approved these changes Dec 19, 2023
View reviewed changes
@kevinssgh kevinssgh changed the title v11.0.0 feat: v11.0.0 Dec 19, 2023
@CharlieMc0 CharlieMc0 merged commit 689c824 into main Dec 19, 2023
23 of 26 checks passed
@CharlieMc0 CharlieMc0 deleted the v11.0.0 branch December 19, 2023 19:51
@fadeev fadeev mentioned this pull request Feb 8, 2024
Closed
@fadeev fadeev mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinssgh kevinssgh kevinssgh approved these changes

@ws4charlie ws4charlie ws4charlie approved these changes

@CharlieMc0 CharlieMc0 CharlieMc0 approved these changes

@lumtis lumtis lumtis approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@kingpinXD kingpinXD Awaiting requested review from kingpinXD kingpinXD is a code owner

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
breaking:cli breaking:proto ci Changes to CI pipeline or github actions nosec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gzukel @lumtis @CharlieMc0 @ws4charlie @kevinssgh @kingpinXD @brewmaster012