refactor(observer): put data from observerParams in coreParams #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lucas Bertrand <[email protected]>
* add tests fro out ts tracker * use getEthereumChainID function in tests --------- Co-authored-by: Lucas Bertrand <[email protected]>
…erwriting. (#13) * add check for existing contract address to avoid overwriting. * Added check for redeployment of gas and asset token contracts Added unit test for this scenario * update changelog --------- Co-authored-by: Lucas Bertrand <[email protected]>
* add pause check * revert on paused * update tests * add smoke test check * goimports * changelog * Update x/crosschain/keeper/evm_deposit.go Co-authored-by: Charlie Chen <[email protected]> --------- Co-authored-by: Charlie Chen <[email protected]>
… allow for rollback (#23) * code hash request * make generate * udpate message * add cli command * udpate smoke tests * changelog * update message name * add check for length * replace log with event * add is contract check
* remove begin block * remove build from smoketest * deploy system contracts message * msg tx * add system contract deployment in smoke tests * start core params refactor * changelog * refactor chains * config refactor * remaining build tags * lint issues * lint issues 2 * gen docs * gen docs 2 * gosec issues 1 * fix cosmos nosec * lint issues * fix core params check * make generate * fix assign * use privnet chains by default * fix chain fetching * use local goerli for smoke tests * remove unamed gosec * address nosec * other goerli net to rename in smoketests * gosec * nosec alerts * nosec alert 2 * use Bitcoin specific network * fix address system contracts * add logs in test * Add more logs * test remaining smoke tests * remove hardcoded ZetaChain chain ID * remove bitcoin hardcoded values * add back smoketests * fix smoke test except cross chain swap * make generate * add log message * fix evm swap contract * fix unit test 1 * fix CLI tests * make generate * fix log error * fix Bitcoin proof test * fix address test * remove network flag and improve smoke tests * add admin group * move core params out of genesis * remove unnecessary RemoveInTxTrackerIfExists * add check for contract failure * Update x/crosschain/keeper/keeper_cross_chain_tx_vote_inbound_tx.go Co-authored-by: Tanmay <[email protected]> * fix install in action * improve events for system contract deploy * error handling for bitcoin net params * add utility functions in common * add stateful smoketest from source * try test fix * fix unit test * fix tests --------- Co-authored-by: Tanmay <[email protected]>
* avoid posting uncessary outtx confirmation * updated changelog.md * added ballot identifier in log prints * unified tx hash variable names * updated changelog * updated changelog
* masked zetaclient config at startup. * fix lint error * add changelog entry * added deep copy --------- Co-authored-by: Lucas Bertrand <[email protected]>
* separated evm/btc cctx schedulers in two different functions * resolve PR comments * sync with develop --------- Co-authored-by: Tanmay <[email protected]> Co-authored-by: Lucas Bertrand <[email protected]>
Co-authored-by: Lucas Bertrand <[email protected]>
* add min gas price to feemarket module at genesis * make zetaclient respect feemarket base fee * add min gas price to feemarket module at genesis * add a nil check * add a default base gas price * rename GetGasPrice * fix build flag in smoketest * fix fee in smoketest broadcast * special ante handler for tx with only 1 msg * add changelog * make linter happy * allow MsgCreateValidator to bypass min gas price check only at genesis time * add more gas limit to address out of gas in smoketest * fix linter complaint * uncomment multiple deposit smoketest * increase smoketest timeout to 35min --------- Co-authored-by: brewmaster012 <>
…ery` and `msg_server` (#60) * out tx tracker * gas price * chain nonces * refactor nonces * last block height * rename some files * add comment * some changes in fungible module * observer part 1 * remaining queries * remove unused messages * fix errors from removed messages * update changelog * remove grpc zevm
* fix sqlite3 errors in docker file builds * add changelog
…on count (#64) * fixed incorrect pending-tx inclusion; fixed incorrect confirmation count * updated changelog --------- Co-authored-by: Lucas Bertrand <[email protected]>
* fixed incorrect pending-tx inclusion; fixed incorrect confirmation count * resolved go-staticcheck warnings in zetaclient * updated changelog
* update proto * implement limit * update changelog * cosmos nosec * set max limit * make generate * remove cctx by status * remove cctx by status proto * rename query * add tests * remove pagination from response * fix client * add total pending in response * fix tests * add nosec * comments
* add chain name * add chain object * changelog --------- Co-authored-by: Tanmay <[email protected]>
* added burn rate metric implementation and unit tests * integrated metrics * add changelog * ran make generate * fix formatting and lint errors * fix lint error * added docs for new functions * cleaned up denomination const and fee calc * fix test case * fix prom gauge * ran make generate * refactored burn rate calculation * used math.Int * ran make generate * clean logs
…#81) * rename to smoketest runner * remove some variables * remove hardcoded account address * reorganize files * refactor btc deployer address * reorg packages part 1 * refactor variable names * refactor test list * fix setup * make generate and changelog * refactor setup * improve zevm setup * make generate * initialize config * update zeta setup * add config and fix test * make generate * use config for rpcs * create package for main * organize cmd package * add readme for smoketest package * fix lint issues * fix address issue --------- Co-authored-by: Charlie Chen <[email protected]>
lumtis
requested review from
a team,
brewmaster012,
kingpinXD,
kevinssgh,
fadeev and
ws4charlie
as code owners
|
Closing for #1436 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ObserverParamsintoCoreParamsto keep all the chain parameters at the same place, updatable through a group proposalObserverParamsas deprecated to simplify migrationUpdateCoreParamsto allow adding new core params with new chain ID (previous implementation onoly allowed updating existant core params and therefore required a state upgrade to add a new chain which is not flexible)RemoveCoreParamsmessage to allow officially removing support to a chainObserverParams->CoreParams