Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add missing cli for fungible module #1426

Merged
merged 16 commits into from
Feb 21, 2024
Merged

feat: Add missing cli for fungible module #1426

merged 16 commits into from
Feb 21, 2024

Conversation

lukema95
Copy link
Contributor

Description

Add missing cli for fungible module. #1356

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis
Copy link
Member

lumtis commented Dec 11, 2023

Hey @lukema95 thank you very much the PRs.
We currently have instituted a code freeze of the repo (cf readme) active until next week.
We will therefore merge your PRs next week

@lukema95
Copy link
Contributor Author

Hey @lukema95 thank you very much the PRs. We currently have instituted a code freeze of the repo (cf readme) active until next week. We will therefore merge your PRs next week

Got it.

@lumtis lumtis requested a review from a team December 22, 2023 07:02
lumtis
lumtis reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I think we can keep it simple for now and keep the PR focused on the CLI

x/fungible/types/message_update_contract_bytecode.go Outdated Show resolved Hide resolved
x/fungible/types/message_update_contract_bytecode_test.go Outdated Show resolved Hide resolved
x/fungible/types/message_update_system_contract.go Outdated Show resolved Hide resolved
x/fungible/types/message_update_zrc20_paused_status.go Outdated Show resolved Hide resolved
x/fungible/types/message_update_zrc20_paused_status_test.go Outdated Show resolved Hide resolved
@lukema95 lukema95 requested a review from skosito as a code owner February 16, 2024 10:03
@lumtis
Copy link
Member

lumtis commented Feb 20, 2024

@lukema95 this is the same problem here with the new line not added in common

@lumtis lumtis merged commit 15f2b4d into zeta-chain:develop Feb 21, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingpinXD kingpinXD kingpinXD approved these changes

@lumtis lumtis lumtis approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie

@skosito skosito Awaiting requested review from skosito

Assignees
No one assigned
Labels
breaking:cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukema95 @lumtis @kingpinXD @ws4charlie