fix(common)!: bitcoin address validation to verify networks

common/address_test.go

@@ -1,3 +1,6 @@
+//go:build TESTNET
+// +build TESTNET
+
 package common
 
 import (

common/chain.go

@@ -60,10 +60,13 @@ func (chain Chain) EncodeAddress(b []byte) (string, error) {
 		if err != nil {
 			return "", err
 		}
-		_, err = btcutil.DecodeAddress(addrStr, chainParams)
+		addr, err := btcutil.DecodeAddress(addrStr, chainParams)
 		if err != nil {
 			return "", err
 		}
+		if !addr.IsForNet(chainParams) {
+			return "", fmt.Errorf("address is not for network %s", chainParams.Name)
+		}
 		return addrStr, nil
 	}
 	return "", fmt.Errorf("chain (%d) not supported", chain.ChainId)

common/chain_test.go

@@ -0,0 +1,55 @@
+package common
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestChain_EncodeAddress(t *testing.T) {
+	type fields struct {
+		ChainName ChainName
+		ChainId   int32
+	}
+
+	tests := []struct {
+		name    string
+		chain   Chain
+		b       []byte
+		want    string
+		wantErr bool
+	}{
+		{
+			name: "should error if b is not a valid address on the network",
+			chain: Chain{
+				ChainName: ChainName_btc_testnet,
+				ChainId:   18332,
+			},
+			b:       []byte("bc1qk0cc73p8m7hswn8y2q080xa4e5pxapnqgp7h9c"),
+			want:    "",
+			wantErr: true,
+		},
+		{
+			name: "should pass if b is a valid address on the network",
+			chain: Chain{
+				ChainName: ChainName_btc_mainnet,
+				ChainId:   8332,
+			},
+			b:       []byte("bc1qk0cc73p8m7hswn8y2q080xa4e5pxapnqgp7h9c"),
+			want:    "bc1qk0cc73p8m7hswn8y2q080xa4e5pxapnqgp7h9c",
+			wantErr: false,
+		},
+	}
+
+	for _, tc := range tests {
+		tc := tc
+		t.Run(tc.name, func(t *testing.T) {
+			s, err := tc.chain.EncodeAddress(tc.b)
+			if tc.wantErr {
+				require.Error(t, err)
+				return
+			}
+			require.Equal(t, tc.want, s)
+		})
+	}
+}