Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set gas limit associated to the ZRC20 for cctx revert outbound #1317

Merged
merged 9 commits into from
Oct 19, 2023

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Oct 18, 2023

Description

Implement a method to get the gas limit for the revert tx for a CCTX (query the gas limit of the associated ZRC20 for the asset sent)

Closes: #1314

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis self-assigned this Oct 18, 2023
@lumtis lumtis marked this pull request as ready for review October 18, 2023 21:56
Copy link
Collaborator

@brewmaster012 brewmaster012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumtis lumtis merged commit ff85f06 into develop Oct 19, 2023
13 checks passed
@lumtis lumtis deleted the refactor/revert-gas-limit branch October 19, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert tx outbound: set the correct gas limit
3 participants