chore: sync from mockmain #1265
Conversation
…1259) * special handling to avoid duplicate payment on bitcoin outbound nonce 0 * use cctx amount instead of txResult's amount because it's not available in bitcoin mainnet --------- Co-authored-by: charliec <[email protected]>
brewmaster012
requested review from
kingpinXD,
kevinssgh,
fadeev,
lumtis and
ws4charlie
as code owners
zetaclient/bitcoin_client.go
Outdated
| // feerate from RPC is BTC/KB, convert it to satoshi/byte | ||
| // FIXME: in zetacore the gaslimit(vsize in BTC) is 100 which is too low for a typical outbound tx | ||
| // until we fix the gaslimit in BTC, we need to multiply the feerate by 20 to make sure the tx is confirmed | ||
| gasPriceU64, _ := gasPrice.Mul(big.NewFloat(*feeResult.FeeRate), big.NewFloat(20*1e5)).Uint64() |
There was a problem hiding this comment.
I don't think we should bring this change to develop now that we can update gas limit
There was a problem hiding this comment.
you are right, we hold off merging to develop until we remove this;
we can remove this adjustment after MsgUpdate gas limit of bitcoin chain
github-actions
bot
added
ci
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
github-actions
bot
removed
ci
…1266) * special handling to avoid duplicate payment on bitcoin outbound nonce 0 * use cctx amount instead of txResult's amount because it's not available in bitcoin mainnet * mockmain bootstrap from double payment on nonce 0 --------- Co-authored-by: charliec <[email protected]>
…k-mainnet-begin-block-deployment
Co-authored-by: charliec <[email protected]>
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: