fix(GetForeignCoinFromAsset): Ethereum comparaison checksum/non-checksum format
#1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev and
ws4charlie
as code owners
brewmaster012
approved these changes
Oct 10, 2023
ws4charlie
added a commit
that referenced
this pull request
Oct 13, 2023
#1292) * refactor: change default mempool version in config (#1238) * fix(`MsgWhitelistERC20`): set unique index for generate cctx (#1245) * update index * remove deprecated functions * make generate * add return value in message * initialize test * whitelist tests * make generate * fix(`observer`): remove error return in `IsAuthorized` (#1250) * update function * regenerate interfaces * update for crosschain * fix(`GetForeignCoinFromAsset`): Ethereum comparaison checksum/non-checksum format (#1261) * fix error message * compare with ETH address type * tests * goimport --------- Co-authored-by: brewmaster012 <[email protected]> * feat(`fungible`): add ability to update gas limit (#1260) * add new field * update message type * message new logic * fix: Blame index update (#1264) * initial commit * added queries and unit tests * added cli * fix parse error * fix parse error 2 * fix lint and test errors * ran make generate * update index for keygen * refactor query name * refactor key calculation * refactor lib name * fix: feed sataoshi/B to zetacore and check actual outTx size (#1243) * feed sataoshi/B to zetacore and check size limit * removed fee cap * replaced magic number 1000 with constant bytesPerKB * put lowerbound, upperbound limit on sizeLimit * use actual txSize for fee calculation --------- Co-authored-by: charliec <[email protected]> * fix: cherry pick all hotfix from v10.0.x (zero-amount, precision, etc.) (#1235) * cherry pick all hotfix from v10.0.x * adjusted code to for nosec * adusted error handling and code comments according to PR review feedback * cherry pick hotfix for bitcoin outbound performance and updated some log prints * cherry pick mock mainnet hotfix for duplicate payment on nonce 0 --------- Co-authored-by: charliec <[email protected]> * fix: register emissions grpc server (#1257) * feat: Bitcoin block header and merkle proof (#1263) * initiated bitcoin header and proof * added smoke test for bitcoin merkle proof and RPC query * make generate * fix gosec and unit test * Update common/headers_test.go Co-authored-by: Lucas Bertrand <[email protected]> * code adjustment according to feedback of PR review * corrected a typo and added more comment to function * fix gosec error --------- Co-authored-by: charliec <[email protected]> Co-authored-by: Lucas Bertrand <[email protected]> Co-authored-by: brewmaster012 <[email protected]> * fix: read gas limit from smart contract (#1277) * read gas limit from smart contract * add more checks for gas limit * fix(`fungible`): add CLI command to query system contract (#1252) * fix proto * fix filename * add cli query * fix(`cmd`): add notice when using `--ledger` with Ethereum HD path (#1285) * change comment * add notice for ledger * merge develop into inbound-tracker and unified proof verification * fixed gosec errors --------- Co-authored-by: Lucas Bertrand <[email protected]> Co-authored-by: brewmaster012 <[email protected]> Co-authored-by: kevinssgh <[email protected]> Co-authored-by: charliec <[email protected]> Co-authored-by: Tanmay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the Ethereum type to compare address independently of the format in
GetForeignCoinFromAssetCloses: #1258
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: