Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error Context in gas_price #1224

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

chinmaym07
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes: #1213

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Screenshot 2023-10-03 at 12 58 59 AM

Checklist:

  • I have added unit tests that prove my fix feature works

@chinmaym07 chinmaym07 changed the title Fixed Error Context in gas_price Fix: Error Context in gas_price Oct 2, 2023
@chinmaym07 chinmaym07 changed the title Fix: Error Context in gas_price fix: Error Context in gas_price Oct 2, 2023
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make the fix in the same PR for SetGasCoin and SetGasZetaPool in the file

x/fungible/keeper/gas_price.go Outdated Show resolved Hide resolved
x/fungible/keeper/gas_price.go Outdated Show resolved Hide resolved
@lumtis
Copy link
Member

lumtis commented Oct 10, 2023

Hi @chinmaym07 do you need any help with the suggestions?
Do you think you still plan to finish this PR?
Thanks

@chinmaym07
Copy link
Contributor Author

Yes @lumtis . Will finish it by today.

@chinmaym07
Copy link
Contributor Author

Screenshot from 2023-10-14 15-52-43

Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@lumtis lumtis merged commit 9997c93 into zeta-chain:develop Oct 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keeper/gas_price.go: loss of error context
3 participants