-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: cross-compile release binaries and simplify PR testings #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieMc0
requested review from
a team,
brewmaster012,
kingpinXD,
kevinssgh,
fadeev,
lumtis and
ws4charlie
as code owners
September 29, 2023 20:11
This was referenced Sep 29, 2023
lumtis
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
billyyang423
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets up goreleaser for cross compiling build and some other release automation. Builds linux, mac, and windows binaries.
goreleaser can handle announcements to our various social channels as well but is not current being used for that.
Reduce the number of steps and checks in the PR testing workflow. More improvements to Smoke Tests speed and stability will come in a future PR
Type of change
CI Change
How Has This Been Tested?
Tested locally with
make release-dry-run
Explanation about Goreleaser vs Makefile
Goreleaser does not directly replace a Makefile. It serves a different purpose:
So Goreleaser complements a Makefile rather than replaces it. Here is a typical workflow using both:
During Development
Release Time
The Makefile is useful for developers working on the project. Goreleaser streamlines the release process and packaging.
Some key differences:
So in summary, Goreleaser does not replace a Makefile but rather complements it by handling releases and packaging. The Makefile is still useful for day-to-day development workflows.