Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(zetaclient): use interfaces for used attributes #1191

Merged
merged 11 commits into from
Oct 24, 2023

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Sep 26, 2023

Description

Define and configure different interfaces to abstract clients for test purposes to increase the ZetaClient coverage in the future.
Interfaces:

  • zetacore bridge
  • Bitcoin RPC client
  • EVM RPC client

Closes: #1154

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis self-assigned this Sep 26, 2023
@lumtis lumtis marked this pull request as ready for review September 26, 2023 15:00
@lumtis lumtis changed the title refactor(zetaclient): use interfaces for various attributes refactor(zetaclient): use interfaces for used attributes Sep 26, 2023
@github-actions
Copy link

!!!WARNING!!!
nosec detected in the following files: zetaclient/bitcoin_client.go, zetaclient/evm_client.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Oct 24, 2023
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kevinssgh kevinssgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left one comment

@lumtis lumtis merged commit 3bec1b5 into develop Oct 24, 2023
13 checks passed
@lumtis lumtis deleted the zetaclient-interfaces branch October 24, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define an interface for ZetaCoreBridge used in zetacore observer
3 participants