fix: Dont't Merge. Staging hotfix v9.0.7 #1172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ws4charlie
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev and
lumtis
as code owners
ws4charlie
changed the title
lumtis
reviewed
Sep 25, 2023
| @@ -108,7 +108,12 @@ func (signer *BTCSigner) SignWithdrawTx(to *btcutil.AddressWitnessPubKeyHash, am | |||
| remaining := total - amount | |||
| remainingSats, err := getSatoshis(remaining) | |||
| if err != nil { | |||
| return nil, err | |||
| // TODO: amount validation should be done in zeta core to block invalid cctx | |||
There was a problem hiding this comment.
I think there are different validaty check that we could perform for a cctx:
- addresses validaty
- amount
- len(outbound) <= 2
Created an issue for it #1180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: