Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tss metrics #1163

Merged
merged 27 commits into from
Sep 21, 2023
Merged

fix: tss metrics #1163

merged 27 commits into from
Sep 21, 2023

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Sep 21, 2023

Description

  • Fix tss metrics initialization.
  • Fix fetching chainID from zetacore

Closes: #1165

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link
Contributor

@kevinssgh kevinssgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kingpinXD kingpinXD merged commit 4547c2b into develop Sep 21, 2023
18 of 19 checks passed
@lumtis lumtis deleted the fix/tss-metrics branch October 27, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zetaclient: crash when keygen fails
3 participants