feat: add new query for pending nonces using chain id #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingpinXD
requested review from
brewmaster012,
kevinssgh,
fadeev,
lumtis and
ws4charlie
as code owners
lumtis
approved these changes
Sep 14, 2023
Comment on lines
+260
to
+267
| message QueryPendingNoncesByChainRequest { | ||
| uint64 chain_id = 1; | ||
| } | ||
|
|
||
| message QueryPendingNoncesByChainResponse { | ||
| PendingNonces pending_nonces = 1 [(gogoproto.nullable) = false]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Not a very big deal but maybe we might want to keep the same order for message definitions as rpc endpoint definitions above
brewmaster012
approved these changes
Sep 15, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds anew query
PendingNoncesByChainCloses:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: