Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crosschain): set cctx as aborted if outbound fails and sender is zeta chain #1107

Merged
merged 3 commits into from
Sep 12, 2023
Merged

fix(crosschain): set cctx as aborted if outbound fails and sender is zeta chain #1107

merged 3 commits into from
Sep 12, 2023

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Sep 11, 2023

Description

Closes: #1069

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis self-assigned this Sep 11, 2023
@lumtis lumtis marked this pull request as ready for review September 11, 2023 13:09
@lumtis lumtis requested a review from ws4charlie September 11, 2023 20:47
ws4charlie
ws4charlie approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with it. It's better if some one really knows the status can take a look.

@lumtis lumtis merged commit f3c6d6e into develop Sep 12, 2023
18 checks passed
@lumtis lumtis deleted the fix/cctx-outbound-failure-abort branch September 12, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ws4charlie ws4charlie ws4charlie approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

Assignees

@lumtis lumtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent creating an outbound tx if cctx outbound is reverted and sender is ZetaChain
3 participants
@lumtis @kingpinXD @ws4charlie