-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rpc
): reduce Ethereum rpc API and improve websocket API
#1106
Conversation
rpc
): reduce Ethereum rpc APIrpc
): reduce Ethereum rpc API and fix improve websocket API
rpc
): reduce Ethereum rpc API and fix improve websocket APIrpc
): reduce Ethereum rpc API and improve websocket API
Could be great to also have a review from @zeta-chain/devops on this, thanks🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lumtis LGTM overall but need one clarification
why do we disable eth_sendTransaction RPC?
As I understand, this is required for Ethereum wallet such as metamask to send tx to our EVM.
@brewmaster012 We use |
From a quick glance, we're using @lumtis are those two getting disabled in this PR or am I looking in the wrong place and it's a different thing? |
Yeah, the Ethereum RPC naming is a bit confusing. You have Unless we have a sytem we're we manage private keys on the node that users can unlock, we should be only using |
Description
eth_sendTransaction
,eth_sign
andeth_signTypedData
To test:
Before:
After
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: