Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fungible): remove BurnCoins usage #1088

Merged
merged 5 commits into from
Sep 11, 2023
Merged

fix(fungible): remove BurnCoins usage #1088

merged 5 commits into from
Sep 11, 2023

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Sep 5, 2023 •
edited
Loading

Description

Remove balance checking and burn
Add notice for usage with temporary context
Add unit tests for the method

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis self-assigned this Sep 5, 2023
@lumtis lumtis marked this pull request as ready for review September 5, 2023 15:52
brewmaster012
brewmaster012 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@brewmaster012 brewmaster012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a run down of existing callers of MinZetaToEVMAccount and they are all using tmpCtx ?

@lumtis
Copy link
Member Author

lumtis commented Sep 6, 2023

Do we have a run down of existing callers of MinZetaToEVMAccount and they are all using tmpCtx ?

Yes, there is a single stack of calls from a tmp ctx calling this one.

@lumtis lumtis merged commit 8778369 into develop Sep 11, 2023
17 checks passed
@lumtis lumtis deleted the fix/remove-burn-coins branch September 11, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@kevinssgh kevinssgh kevinssgh approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie

Assignees

@lumtis lumtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lumtis @kingpinXD @kevinssgh @brewmaster012