PR comments

zeta-chain · May 16, 2024 · fefe6b2 · fefe6b2
1 parent 4cd3cf9
commit fefe6b2
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/app/ante/ante.go b/app/ante/ante.go
@@ -172,6 +172,7 @@ func IsSystemTx(tx sdk.Tx, isAuthorizedSigner func(string) bool) bool {
 		*crosschaintypes.MsgVoteOnObservedInboundTx,
 		*crosschaintypes.MsgVoteOnObservedOutboundTx,
 		*crosschaintypes.MsgAddToOutTxTracker,
+		*crosschaintypes.MsgAddToInTxTracker,
 		*observertypes.MsgVoteBlockHeader,
 		*observertypes.MsgVoteTSS,
 		*observertypes.MsgAddBlameVote:

diff --git a/app/ante/ante_test.go b/app/ante/ante_test.go
@@ -36,6 +36,7 @@ func TestIsSystemTx(t *testing.T) {
 	//		*cctxtypes.MsgVoteOnObservedInboundTx,
 	//		*cctxtypes.MsgVoteOnObservedOutboundTx,
 	//		*cctxtypes.MsgAddToOutTxTracker,
+	//		*cctxtypes.MsgAddToInTxTracker,
 	//		*observertypes.MsgVoteBlockHeader,
 	//		*observertypes.MsgVoteTSS,
 	//		*observertypes.MsgAddBlameVote:
@@ -168,6 +169,24 @@ func TestIsSystemTx(t *testing.T) {
 
 			true,
 		},
+		{
+			"MsgAddToInTxTracker",
+			buildTxFromMsg(&crosschaintypes.MsgAddToInTxTracker{
+				Creator: sample.AccAddress(),
+			}),
+			isAuthorized,
+
+			true,
+		},
+		{
+			"MsgExec{MsgAddToInTxTracker}",
+			buildAuthzTxFromMsg(&crosschaintypes.MsgAddToInTxTracker{
+				Creator: sample.AccAddress(),
+			}),
+			isAuthorized,
+
+			true,
+		},
 		{
 			"MsgVoteTSS",
 			buildTxFromMsg(&observertypes.MsgVoteTSS{

diff --git a/cmd/zetae2e/local/monitor_priority_txs.go b/cmd/zetae2e/local/monitor_priority_txs.go
@@ -71,6 +71,7 @@ func processTx(txResult *coretypes.ResultTx, nonSystemTxFound *bool, errCh chan
 					// a non system tx has been found in the block before a system tx
 					if *nonSystemTxFound {
 						errCh <- errors.New("wrong tx priority, system tx not on top")
+						return
 					}
 				} else {
 					*nonSystemTxFound = true
@@ -92,6 +93,7 @@ func isMsgTypeURLSystemTx(attr types.EventAttribute) bool {
 		"\"/zetachain.zetacore.crosschain.MsgVoteOnObservedInboundTx\"",
 		"\"/zetachain.zetacore.crosschain.MsgVoteGasPrice\"",
 		"\"/zetachain.zetacore.crosschain.MsgAddToOutTxTracker\"",
+		"\"/zetachain.zetacore.crosschain.MsgAddToInTxTracker\"",
 		"\"/zetachain.zetacore.observer.MsgVoteBlockHeader\"",
 		"\"/zetachain.zetacore.observer.MsgVoteTSS\"",
 		"\"/zetachain.zetacore.observer.MsgAddBlameVote\"",