Skip to content

Commit

Permalink
do not fail fast, use newer action versions
Browse files Browse the repository at this point in the history
  • Loading branch information
gartnera committed Jul 3, 2024
1 parent f9c1d46 commit ed620d8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
e2e:
needs: matrix-conditionals
strategy:
fail-fast: false
matrix:
include:
- make-target: "start-e2e-test"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/reusable-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ jobs:
- uses: depot/use-containerd-snapshotter-action@v1

- name: Login to Docker Hub registry
uses: docker/login-action@v2
uses: docker/login-action@v3
if: (github.event_name == 'push' && github.repository == 'zeta-chain/node') || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'zeta-chain/node')
with:
username: ${{ secrets.DOCKER_HUB_USERNAME }}
password: ${{ secrets.DOCKER_HUB_READ_ONLY }}

- name: Login to github docker registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
- name: Upload Logs On Failure
if: failure()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.make-target }}-docker-logs
path: /tmp/logs.txt
Expand Down

0 comments on commit ed620d8

Please sign in to comment.