add two more unit tests for missed lines

zeta-chain · Oct 10, 2024 · c48d999 · c48d999
1 parent 416b8d4
commit c48d999
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/pkg/memo/codec_compact_test.go b/pkg/memo/codec_compact_test.go
@@ -234,6 +234,15 @@ func Test_CodecCompact_UnpackArguments(t *testing.T) {
 				memo.ArgRevertAddress(""),
 			},
 		},
+		{
+			name:        "failed to unpack address if data length < 20 bytes",
+			encodingFmt: memo.EncodingFmtCompactShort,
+			data:        []byte{0x01, 0x02, 0x03, 0x04, 0x05},
+			expected: []memo.CodecArg{
+				memo.ArgReceiver(argAddress),
+			},
+			errMsg: "expected address, got 5 bytes",
+		},
 		{
 			name:        "failed to unpack string if data length < 1 byte",
 			encodingFmt: memo.EncodingFmtCompactShort,

diff --git a/pkg/memo/fields_v0_test.go b/pkg/memo/fields_v0_test.go
@@ -212,6 +212,14 @@ func Test_V0_Unpack(t *testing.T) {
 				Payload:  []byte{},
 			},
 		},
+		{
+			name:           "unable to get codec on invalid encoding format",
+			opCode:         memo.OpCodeDepositAndCall,
+			encodingFormat: 0x0F,
+			flags:          0b00000001,
+			data:           []byte{},
+			errMsg:         "unable to get codec",
+		},
 		{
 			name:           "failed to unpack ABI encoded data with compact encoding format",
 			opCode:         memo.OpCodeDepositAndCall,