Add todos

zeta-chain · May 28, 2024 · c0b8891 · c0b8891
1 parent 51761da
commit c0b8891
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/rpc/backend/blocks.go b/rpc/backend/blocks.go
@@ -263,6 +263,7 @@ func (b *Backend) BlockNumberFromTendermintByHash(blockHash common.Hash) (*big.I
 // EthMsgsFromTendermintBlock returns all real MsgEthereumTxs from a
 // Tendermint block. It also ensures consistency over the correct txs indexes
 // across RPC endpoints
+// TODO: check if additionals array can be removed
 func (b *Backend) EthMsgsFromTendermintBlock(
 	resBlock *tmrpctypes.ResultBlock,
 	blockRes *tmrpctypes.ResultBlockResults,

diff --git a/rpc/types/utils.go b/rpc/types/utils.go
@@ -170,6 +170,7 @@ func NewTransactionFromMsg(
 	chainID *big.Int,
 	txAdditional *TxResultAdditionalFields,
 ) (*RPCTransaction, error) {
+	// TODO: check if this condition can be removed
 	if txAdditional != nil {
 		return NewRPCTransactionFromIncompleteMsg(msg, blockHash, blockNumber, index, baseFee, chainID, txAdditional)
 	}