Skip to content

Commit

Permalink
Remove redundant todos
Browse files Browse the repository at this point in the history
  • Loading branch information
skosito committed Apr 1, 2024
1 parent 60fb2b1 commit 9aae130
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
1 change: 0 additions & 1 deletion x/observer/types/parsers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ func TestParseStringToObservationType(t *testing.T) {
{"TestValidObservationType1", "OutBoundTx", types.ObservationType(2)},
{"TestValidObservationType1", "TSSKeyGen", types.ObservationType(3)},
{"TestValidObservationType1", "TSSKeySign", types.ObservationType(4)},
// TODO: this is wrong, ObservationType should check if value exists?
{"TestInvalidObservationType", "InvalidType", types.ObservationType(0)},
}

Expand Down
10 changes: 4 additions & 6 deletions x/observer/types/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,13 @@ func TestConvertNodes(t *testing.T) {
expected []*types.Node
}{
{
name: "TestEmptyInput",
input: []blame.Node{},
// TODO: is nil ok here, should be empty array?
name: "TestEmptyInput",
input: []blame.Node{},
expected: nil,
},
{
name: "TestNilInput",
input: nil,
// TODO: is nil ok here, should be empty array?
name: "TestNilInput",
input: nil,
expected: nil,
},
{
Expand Down

0 comments on commit 9aae130

Please sign in to comment.