address from comments

zeta-chain · Jul 22, 2024 · 85eef7c · 85eef7c
1 parent 9f2a418
commit 85eef7c
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 23 deletions.
diff --git a/proto/zetachain/zetacore/observer/chain_nonces.proto b/proto/zetachain/zetacore/observer/chain_nonces.proto
@@ -9,7 +9,8 @@ message ChainNonces {
   string creator = 1;
 
   // deprecated(v19): index has been replaced by chain_id for unique identifier
-  string index = 2 [deprecated = true];;
+  string index = 2 [ deprecated = true ];
+  ;
 
   int64 chain_id = 3;
   uint64 nonce = 4;

diff --git a/typescript/zetachain/zetacore/observer/chain_nonces_pb.d.ts b/typescript/zetachain/zetacore/observer/chain_nonces_pb.d.ts
@@ -18,7 +18,8 @@ export declare class ChainNonces extends Message<ChainNonces> {
   /**
    * deprecated(v19): index has been replaced by chain_id for unique identifier
    *
-   * @generated from field: string index = 2;
+   * @generated from field: string index = 2 [deprecated = true];
+   * @deprecated
    */
   index: string;
 

diff --git a/x/observer/migrations/v8/migrate_test.go b/x/observer/migrations/v8/migrate_test.go
@@ -92,14 +92,14 @@ func TestMigrateStore(t *testing.T) {
 		allChainNonces = k.GetAllChainNonces(ctx)
 		require.Len(t, allChainNonces, 10)
 
-		chainIDMap := make(map[int64]bool)
+		chainIDMap := make(map[int64]struct{})
 
 		// all chain nonces can be found in the store
 		for _, chainNonces := range allChainNonces {
 			// chain all chain IDs are different
 			_, found := chainIDMap[chainNonces.ChainId]
 			require.False(t, found)
-			chainIDMap[chainNonces.ChainId] = true
+			chainIDMap[chainNonces.ChainId] = struct{}{}
 
 			// check value
 			retrievedChainNonces, found := k.GetChainNonces(ctx, chainNonces.ChainId)

diff --git a/x/observer/types/chain_nonces.pb.go b/x/observer/types/chain_nonces.pb.go