Add ballot types test and remove redundant test data file

x/observer/keeper/params_test.go

@@ -1,4 +1,4 @@
-package keeper
+package keeper_test
 
 import (
 	"fmt"
@@ -9,11 +9,13 @@ import (
 	"github.com/tendermint/tendermint/crypto"
 
 	"github.com/stretchr/testify/require"
+	testutilkeeper "github.com/zeta-chain/zetacore/testutil/keeper"
+	"github.com/zeta-chain/zetacore/x/observer/keeper"
 	"github.com/zeta-chain/zetacore/x/observer/types"
 )
 
 func TestGetParams(t *testing.T) {
-	k, ctx := SetupKeeper(t)
+	k, ctx := keeper.SetupKeeper(t)
 	params := types.DefaultParams()
 
 	k.SetParams(ctx, params)
@@ -22,7 +24,7 @@ func TestGetParams(t *testing.T) {
 }
 
 func TestGenerateAddress(t *testing.T) {
-	types.SetConfig(false)
+	testutilkeeper.SetConfig(false)
 	addr := sdk.AccAddress(crypto.AddressHash([]byte("Output1" + strconv.Itoa(1))))
 	addrString := addr.String()
 	fmt.Println(addrString)

x/observer/types/ballot.go

@@ -14,12 +14,18 @@ func (m Ballot) AddVote(address string, vote VoteType) (Ballot, error) {
 	// `index` is the index of the `address` in the `VoterList`
 	// `index` is used to set the vote in the `Votes` array
 	index := m.GetVoterIndex(address)
+	if index == -1 {
+		return m, errors.Wrap(ErrUnableToAddVote, fmt.Sprintf("Voter %s not in voter list", address))
+	}
 	m.Votes[index] = vote
 	return m, nil
 }
 
 func (m Ballot) HasVoted(address string) bool {
 	index := m.GetVoterIndex(address)
+	if index == -1 {
+		return false
+	}
 	return m.Votes[index] != VoteType_NotYetVoted
 }
 

x/observer/types/ballot_test.go

@@ -21,6 +21,7 @@ func TestBallot_AddVote(t *testing.T) {
 		finalVotes  []VoteType
 		finalStatus BallotStatus
 		isFinalized bool
+		wantErr     bool
 	}{
 		{
 			name:      "All success",
@@ -188,6 +189,18 @@ func TestBallot_AddVote(t *testing.T) {
 			finalStatus: BallotStatus_BallotInProgress,
 			isFinalized: false,
 		},
+		{
+			name:      "Voter not in voter list",
+			threshold: sdk.MustNewDecFromStr("0.66"),
+			voterList: []string{},
+			votes: []votes{
+				{"Observer5", VoteType_SuccessObservation},
+			},
+			wantErr:     true,
+			finalVotes:  []VoteType{},
+			finalStatus: BallotStatus_BallotInProgress,
+			isFinalized: false,
+		},
 	}
 	for _, test := range tt {
 		test := test
@@ -202,7 +215,11 @@ func TestBallot_AddVote(t *testing.T) {
 				BallotStatus:     BallotStatus_BallotInProgress,
 			}
 			for _, vote := range test.votes {
-				ballot, _ = ballot.AddVote(vote.address, vote.vote)
+				b, err := ballot.AddVote(vote.address, vote.vote)
+				if test.wantErr {
+					require.Error(t, err)
+				}
+				ballot = b
 			}
 
 			finalBallot, isFinalized := ballot.IsFinalizingVote()