Fixes

zeta-chain · Apr 11, 2024 · 6aad8db · 6aad8db
1 parent dbfb052
commit 6aad8db
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 16 deletions.
diff --git a/x/emissions/migrations/v3/migrate_test.go b/x/emissions/migrations/v3/migrate_test.go
@@ -30,7 +30,7 @@ func TestMigrate(t *testing.T) {
 
 	legacyParams := types.Params{
 		MaxBondFactor:               "1",
-		MinBondFactor:               "0.50",
+		MinBondFactor:               "0.75",
 		AvgBlockTime:                "5.00",
 		TargetBondRatio:             "00.50",
 		ValidatorEmissionPercentage: "00.50",

diff --git a/x/emissions/types/genesis_test.go b/x/emissions/types/genesis_test.go
@@ -18,11 +18,6 @@ func TestGenesisState_Validate(t *testing.T) {
 			genState: types.DefaultGenesis(),
 			valid:    true,
 		},
-		{
-			desc:     "valid genesis state",
-			genState: &types.GenesisState{},
-			valid:    true,
-		},
 	} {
 		t.Run(tc.desc, func(t *testing.T) {
 			err := tc.genState.Validate()

diff --git a/x/emissions/types/message_update_params.go b/x/emissions/types/message_update_params.go
@@ -26,9 +26,5 @@ func (m *MsgUpdateParams) ValidateBasic() error {
 		return cosmoserrors.Wrapf(sdkerrors.ErrInvalidAddress, "invalid authority address (%s)", err)
 	}
 
-	if err := m.Params.Validate(); err != nil {
-		return err
-	}
-
-	return nil
+	return m.Params.Validate()
 }
diff --git a/x/observer/types/message_update_params.go b/x/observer/types/message_update_params.go
@@ -26,9 +26,5 @@ func (m *MsgUpdateParams) ValidateBasic() error {
 		return cosmoserrors.Wrapf(sdkerrors.ErrInvalidAddress, "invalid authority address (%s)", err)
 	}
 
-	if err := m.Params.Validate(); err != nil {
-		return err
-	}
-
-	return nil
+	return m.Params.Validate()
 }