ci: fix docker release pipeline tag issue. (#2189)

* updated the docker build to utilize the github event release title and removed the mac build because the arm build covers that. * updated change log
zeta-chain · May 15, 2024 · 5ee5fcc · 5ee5fcc
1 parent b63b5dc
commit 5ee5fcc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 62 deletions.
diff --git a/.github/workflows/docker-build-and-push.yml b/.github/workflows/docker-build-and-push.yml
@@ -29,15 +29,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set Version from the PR title.
+      - name: Set Version from the release title.
         if: github.event_name != 'workflow_dispatch'
         run: |
-          LATEST_RELEASE=$(curl -s -H "Accept: application/vnd.github+json" \
-          -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
-          https://api.github.com/repos/${{ github.repository }}/releases/latest)
-          RELEASE_TITLE=$(echo $LATEST_RELEASE | jq -r .name)
-          echo "Latest release title: $RELEASE_TITLE"
-          echo "GITHUB_TAG_MAJOR_VERSION=$RELEASE_TITLE" >> $GITHUB_ENV
+          echo "GITHUB_TAG_MAJOR_VERSION=${{ github.event.release.name }}" >> $GITHUB_ENV
 
       - name: Set Version for Hotfix Release from Input.
         if: github.event_name != 'pull_request'
@@ -58,54 +53,6 @@ jobs:
           DOCKER_BUILD_KIT: "0"
           TAG_LATEST: "true"
 
-  docker_build_mac:
-    runs-on: macos-latest
-    timeout-minutes: 120
-    steps:
-      - uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-
-      - name: Set Version from the PR title.
-        if: github.event_name != 'workflow_dispatch'
-        run: |
-          LATEST_RELEASE=$(curl -s -H "Accept: application/vnd.github+json" \
-          -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
-          https://api.github.com/repos/${{ github.repository }}/releases/latest)
-          RELEASE_TITLE=$(echo $LATEST_RELEASE | jq -r .name)
-          echo "Latest release title: $RELEASE_TITLE"
-          echo "GITHUB_TAG_MAJOR_VERSION=$RELEASE_TITLE" >> $GITHUB_ENV
-
-      - name: Set Version for Hotfix Release from Input.
-        if: github.event_name != 'pull_request'
-        run: |
-          echo "GITHUB_TAG_MAJOR_VERSION=${{ github.event.inputs.version }}" >> ${GITHUB_ENV}
-
-      - name: Setup docker and docker-compose (missing on MacOS)
-        if: runner.os == 'macos'
-        run: |
-          brew install docker docker-compose
-          
-          # Link the Docker Compose v2 plugin so it's understood by the docker CLI
-          mkdir -p ~/.docker/cli-plugins
-          ln -sfn /usr/local/opt/docker-compose/bin/docker-compose ~/.docker/cli-plugins/docker-compose
-          
-          colima start
-
-      - name: "BUILD:PUSH:MONITORING:DOCKER:IMAGE"
-        uses: ./.github/actions/build-docker-images-generic
-        with:
-          DOCKER_FILENAME: "Dockerfile"
-          REPOSITORY_NAME: "${{ env.DOCKER_REPO }}"
-          IMAGE_TAG: "mac-${{ env.GITHUB_TAG_MAJOR_VERSION }}"
-          REGISTRY: "${{ env.DOCKER_REGISTRY }}"
-          DOCKER_ORG: "${{ env.DOCKER_ORG }}"
-          USERNAME: "${{ secrets.DOCKER_HUB_USERNAME }}"
-          TOKEN: "${{ secrets.DOCKERHUB_TOKEN }}"
-          DOCKER_FILE_DIRECTORY: "./"
-          DOCKER_BUILD_KIT: "0"
-          TAG_LATEST: "false"
-
   docker_build_arm:
     runs-on: buildjet-4vcpu-ubuntu-2204-arm
     timeout-minutes: 30
@@ -114,15 +61,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set Version from the PR title.
+      - name: Set Version from the release title.
         if: github.event_name != 'workflow_dispatch'
         run: |
-          LATEST_RELEASE=$(curl -s -H "Accept: application/vnd.github+json" \
-          -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
-          https://api.github.com/repos/${{ github.repository }}/releases/latest)
-          RELEASE_TITLE=$(echo $LATEST_RELEASE | jq -r .name)
-          echo "Latest release title: $RELEASE_TITLE"
-          echo "GITHUB_TAG_MAJOR_VERSION=$RELEASE_TITLE" >> $GITHUB_ENV
+          echo "GITHUB_TAG_MAJOR_VERSION=${{ github.event.release.name }}" >> $GITHUB_ENV
 
       - name: Set Version for Hotfix Release from Input.
         if: github.event_name != 'pull_request'

diff --git a/changelog.md b/changelog.md
@@ -39,6 +39,7 @@
 
 * [2070](https://github.com/zeta-chain/node/pull/2070) - Added commands to build binaries from the working branch as a live full node rpc to test non-governance changes.
 * [2119](https://github.com/zeta-chain/node/pull/2119) - Updated the release pipeline to only run on hotfix/ and release/ branches. Added option to only run pre-checks and not cut release as well. Switched approval steps to use environments.
+* [2189](https://github.com/zeta-chain/node/pull/2189) - Updated the docker tag when a release trigger runs to be the github event for the release name which should be the version. Removed mac specific build as the arm build should handle that.
 
 ## v16.0.0