disable chain migration test

zeta-chain · Apr 3, 2024 · 5d93e26 · 5d93e26
1 parent 41f1386
commit 5d93e26
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/cmd/zetae2e/local/local.go b/cmd/zetae2e/local/local.go
@@ -285,7 +285,12 @@ func localE2ETest(cmd *cobra.Command, _ []string) {
 			e2etests.TestPauseZRC20Name,
 			e2etests.TestUpdateBytecodeName,
 			e2etests.TestDepositEtherLiquidityCapName,
-			e2etests.TestMigrateChainSupportName,
+
+			// TestMigrateChainSupportName tests EVM chain migration. Currently this test doesn't work with Anvil because pre-EIP1559 txs are not supported
+			// See issue below for details
+			// TODO: renenable this test as per the issue below
+			// https://github.com/zeta-chain/node/issues/1980
+			// e2etests.TestMigrateChainSupportName,
 		))
 	}
 	if testPerformance {

diff --git a/zetaclient/evm/evm_signer.go b/zetaclient/evm/evm_signer.go
@@ -142,6 +142,8 @@ func (signer *Signer) Sign(
 ) (*ethtypes.Transaction, []byte, []byte, error) {
 	log.Debug().Msgf("TSS SIGNER: %s", signer.tssSigner.Pubkey())
 
+	// TODO: use EIP-1559 transaction type
+	// https://github.com/zeta-chain/node/issues/1952
 	tx := ethtypes.NewTransaction(nonce, to, big.NewInt(0), gasLimit, gasPrice, data)
 
 	hashBytes := signer.ethSigner.Hash(tx).Bytes()
@@ -251,6 +253,8 @@ func (signer *Signer) SignRevertTx(txData *OutBoundTransactionData) (*ethtypes.T
 
 // SignCancelTx signs a transaction from TSS address to itself with a zero amount in order to increment the nonce
 func (signer *Signer) SignCancelTx(nonce uint64, gasPrice *big.Int, height uint64) (*ethtypes.Transaction, error) {
+	// TODO: use EIP-1559 transaction type
+	// https://github.com/zeta-chain/node/issues/1952
 	tx := ethtypes.NewTransaction(nonce, signer.tssSigner.EVMAddress(), big.NewInt(0), 21000, gasPrice, nil)
 
 	hashBytes := signer.ethSigner.Hash(tx).Bytes()
@@ -274,6 +278,8 @@ func (signer *Signer) SignCancelTx(nonce uint64, gasPrice *big.Int, height uint6
 
 // SignWithdrawTx signs a withdrawal transaction sent from the TSS address to the destination
 func (signer *Signer) SignWithdrawTx(txData *OutBoundTransactionData) (*ethtypes.Transaction, error) {
+	// TODO: use EIP-1559 transaction type
+	// https://github.com/zeta-chain/node/issues/1952
 	tx := ethtypes.NewTransaction(txData.nonce, txData.to, txData.amount, 21000, txData.gasPrice, nil)
 
 	hashBytes := signer.ethSigner.Hash(tx).Bytes()