fix(crosschain): do not check zetachain sender for failed revert outb…

…ound (#3166)

* fix(crosschain): do not check zetachain sender for failed revert outbound

* fix fix newline

* fix comment

x/crosschain/keeper/cctx_orchestrator_validate_outbound.go

@@ -320,26 +320,25 @@ func (k Keeper) processFailedZETAOutboundOnZEVM(ctx sdk.Context, cctx *types.Cro
 
 // processFailedOutboundV2 processes a failed outbound transaction for protocol version 2
 // for revert, in V2 we have some assumption simplifying the logic
-// - sender chain is always ZetaChain
+// - sender chain is ZetaChain for regular outbound (not revert outbound)
 // - all coin type use the same workflow
 // TODO: consolidate logic with above function
 // https://github.com/zeta-chain/node/issues/2627
 func (k Keeper) processFailedOutboundV2(ctx sdk.Context, cctx *types.CrossChainTx) error {
-	// check the sender is ZetaChain
-	zetaChain, err := chains.ZetaChainFromCosmosChainID(ctx.ChainID())
-	if err != nil {
-		return errors.Wrap(err, "failed to get ZetaChain chainID")
-	}
-	if cctx.InboundParams.SenderChainId != zetaChain.ChainId {
-		return fmt.Errorf(
-			"sender chain for withdraw cctx is not ZetaChain expected %d got %d",
-			zetaChain.ChainId,
-			cctx.InboundParams.SenderChainId,
-		)
-	}
-
 	switch cctx.CctxStatus.Status {
 	case types.CctxStatus_PendingOutbound:
+		// check the sender is ZetaChain
+		zetaChain, err := chains.ZetaChainFromCosmosChainID(ctx.ChainID())
+		if err != nil {
+			return errors.Wrap(err, "failed to get ZetaChain chainID")
+		}
+		if cctx.InboundParams.SenderChainId != zetaChain.ChainId {
+			return fmt.Errorf(
+				"sender chain for withdraw cctx is not ZetaChain expected %d got %d",
+				zetaChain.ChainId,
+				cctx.InboundParams.SenderChainId,
+			)
+		}
 
 		//  get the chain ID of the connected chain
 		chainID := cctx.GetCurrentOutboundParam().ReceiverChainId