PR comments

rpc/backend/account_info_test.go

@@ -415,7 +415,7 @@ func (suite *BackendTestSuite) TestGetTransactionCount() {
 			false,
 			hexutil.Uint64(0),
 		},
-		// TODO: Error mocking the GetAccount call - problem with Any type
+		// TODO (https://github.com/zeta-chain/node/issues/2302): Error mocking the GetAccount call - problem with Any type
 		//{
 		//	"pass - returns the number of transactions at the given address up to the given block number",
 		//	true,

rpc/backend/backend_suite_test.go

@@ -39,7 +39,7 @@ func TestBackendTestSuite(t *testing.T) {
 	suite.Run(t, new(BackendTestSuite))
 }
 
-const ChainID = "ethermint_9000-1"
+const ChainID = "zetachain_7001-1"
 
 // SetupTest is executed before every BackendTestSuite test
 func (suite *BackendTestSuite) SetupTest() {
@@ -188,7 +188,7 @@ func (suite *BackendTestSuite) signAndEncodeEthTx(msgEthereumTx *evmtypes.MsgEth
 	err := msgEthereumTx.Sign(ethSigner, signer)
 	suite.Require().NoError(err)
 
-	tx, err := msgEthereumTx.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "aphoton")
+	tx, err := msgEthereumTx.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "azeta")
 	suite.Require().NoError(err)
 
 	txEncoder := suite.backend.clientCtx.TxConfig.TxEncoder()

rpc/backend/call_tx_test.go

@@ -274,7 +274,7 @@ func (suite *BackendTestSuite) TestSendRawTransaction() {
 	ethTx, bz := suite.buildEthereumTx()
 	rlpEncodedBz, err := rlp.EncodeToBytes(ethTx.AsTransaction())
 	suite.Require().NoError(err)
-	cosmosTx, err := ethTx.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "aphoton")
+	cosmosTx, err := ethTx.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "azeta")
 	suite.Require().NoError(err)
 	txBytes, err := suite.backend.clientCtx.TxConfig.TxEncoder()(cosmosTx)
 	suite.Require().NoError(err)

rpc/backend/chain_info_test.go

@@ -151,7 +151,7 @@ func (suite *BackendTestSuite) TestBaseFee() {
 }
 
 func (suite *BackendTestSuite) TestChainId() {
-	expChainId := (*hexutil.Big)(big.NewInt(9000))
+	expChainId := (*hexutil.Big)(big.NewInt(7001))
 	testCases := []struct {
 		name         string
 		registerMock func()

rpc/backend/client_test.go

@@ -278,7 +278,7 @@ func RegisterABCIQueryWithOptions(
 	client.On("ABCIQueryWithOptions", context.Background(), path, data, opts).
 		Return(&tmrpctypes.ResultABCIQuery{
 			Response: abci.ResponseQuery{
-				Value:  []byte{2}, // TODO replace with data.Bytes(),
+				Value:  []byte{2}, // TODO (https://github.com/zeta-chain/node/issues/2302) replace with data.Bytes(),
 				Height: height,
 			},
 		}, nil)

rpc/backend/evm_query_client_test.go

@@ -40,18 +40,18 @@ func RegisterTraceTransactionWithPredecessors(
 ) {
 	data := []byte{0x7b, 0x22, 0x74, 0x65, 0x73, 0x74, 0x22, 0x3a, 0x20, 0x22, 0x68, 0x65, 0x6c, 0x6c, 0x6f, 0x22, 0x7d}
 	queryClient.On("TraceTx", rpc.ContextWithHeight(1),
-		&evmtypes.QueryTraceTxRequest{Msg: msgEthTx, BlockNumber: 1, Predecessors: predecessors, ChainId: 9000}).
+		&evmtypes.QueryTraceTxRequest{Msg: msgEthTx, BlockNumber: 1, Predecessors: predecessors, ChainId: 7001}).
 		Return(&evmtypes.QueryTraceTxResponse{Data: data}, nil)
 }
 
 func RegisterTraceTransaction(queryClient *mocks.EVMQueryClient, msgEthTx *evmtypes.MsgEthereumTx) {
 	data := []byte{0x7b, 0x22, 0x74, 0x65, 0x73, 0x74, 0x22, 0x3a, 0x20, 0x22, 0x68, 0x65, 0x6c, 0x6c, 0x6f, 0x22, 0x7d}
-	queryClient.On("TraceTx", rpc.ContextWithHeight(1), &evmtypes.QueryTraceTxRequest{Msg: msgEthTx, BlockNumber: 1, Predecessors: []*evmtypes.MsgEthereumTx{}, ChainId: 9000}).
+	queryClient.On("TraceTx", rpc.ContextWithHeight(1), &evmtypes.QueryTraceTxRequest{Msg: msgEthTx, BlockNumber: 1, Predecessors: []*evmtypes.MsgEthereumTx{}, ChainId: 7001}).
 		Return(&evmtypes.QueryTraceTxResponse{Data: data}, nil)
 }
 
 func RegisterTraceTransactionError(queryClient *mocks.EVMQueryClient, msgEthTx *evmtypes.MsgEthereumTx) {
-	queryClient.On("TraceTx", rpc.ContextWithHeight(1), &evmtypes.QueryTraceTxRequest{Msg: msgEthTx, BlockNumber: 1, ChainId: 9000}).
+	queryClient.On("TraceTx", rpc.ContextWithHeight(1), &evmtypes.QueryTraceTxRequest{Msg: msgEthTx, BlockNumber: 1, ChainId: 7001}).
 		Return(nil, errortypes.ErrInvalidRequest)
 }
 
@@ -65,7 +65,7 @@ func RegisterTraceBlock(queryClient *mocks.EVMQueryClient, txs []*evmtypes.MsgEt
 			Txs:         txs,
 			BlockNumber: 1,
 			TraceConfig: &evmtypes.TraceConfig{},
-			ChainId:     9000,
+			ChainId:     7001,
 		},
 	).
 		Return(&evmtypes.QueryTraceBlockResponse{Data: data}, nil)
@@ -90,8 +90,10 @@ func RegisterParams(queryClient *mocks.EVMQueryClient, header *metadata.MD, heig
 }
 
 func RegisterParamsWithoutHeader(queryClient *mocks.EVMQueryClient, height int64) {
+	params := evmtypes.DefaultParams()
+	params.EvmDenom = "azeta"
 	queryClient.On("Params", rpc.ContextWithHeight(height), &evmtypes.QueryParamsRequest{}).
-		Return(&evmtypes.QueryParamsResponse{Params: evmtypes.DefaultParams()}, nil)
+		Return(&evmtypes.QueryParamsResponse{Params: params}, nil)
 }
 
 func RegisterParamsInvalidHeader(queryClient *mocks.EVMQueryClient, header *metadata.MD, height int64) {

rpc/backend/node_info_test.go

@@ -96,7 +96,7 @@ func (suite *BackendTestSuite) TestSetGasPrice() {
 	}
 }
 
-// TODO: Combine these 2 into one test since the code is identical
+// TODO (https://github.com/zeta-chain/node/issues/2302): Combine these 2 into one test since the code is identical
 func (suite *BackendTestSuite) TestListAccounts() {
 	testCases := []struct {
 		name         string
@@ -255,7 +255,7 @@ func (suite *BackendTestSuite) TestSetEtherbase() {
 				RegisterStatus(client)
 				RegisterValidatorAccount(queryClient, suite.acc)
 				RegisterParams(queryClient, &header, 1)
-				c := sdk.NewDecCoin("aphoton", sdk.NewIntFromBigInt(big.NewInt(1)))
+				c := sdk.NewDecCoin("azeta", sdk.NewIntFromBigInt(big.NewInt(1)))
 				suite.backend.cfg.SetMinGasPrices(sdk.DecCoins{c})
 				delAddr, _ := suite.backend.GetCoinbase()
 				// account, _ := suite.backend.clientCtx.AccountRetriever.GetAccount(suite.backend.clientCtx, delAddr)
@@ -272,15 +272,15 @@ func (suite *BackendTestSuite) TestSetEtherbase() {
 			common.Address{},
 			false,
 		},
-		// TODO: Finish this test case once ABCIQuery GetAccount is fixed
+		// TODO (https://github.com/zeta-chain/node/issues/2302): Finish this test case once ABCIQuery GetAccount is fixed
 		//{
 		//	"pass - set the etherbase for the miner",
 		//	func() {
 		//		client := suite.backend.clientCtx.Client.(*mocks.Client)
 		//		queryClient := suite.backend.queryClient.QueryClient.(*mocks.EVMQueryClient)
 		//		RegisterStatus(client)
 		//		RegisterValidatorAccount(queryClient, suite.acc)
-		//		c := sdk.NewDecCoin("aphoton", sdk.NewIntFromBigInt(big.NewInt(1)))
+		//		c := sdk.NewDecCoin("azeta", sdk.NewIntFromBigInt(big.NewInt(1)))
 		//		suite.backend.cfg.SetMinGasPrices(sdk.DecCoins{c})
 		//		delAddr, _ := suite.backend.GetCoinbase()
 		//		account, _ := suite.backend.clientCtx.AccountRetriever.GetAccount(suite.backend.clientCtx, delAddr)

rpc/backend/sign_tx_test.go

@@ -106,7 +106,7 @@ func (suite *BackendTestSuite) TestSendTransaction() {
 				ethSigner := ethtypes.LatestSigner(suite.backend.ChainConfig())
 				msg := callArgsDefault.ToTransaction()
 				msg.Sign(ethSigner, suite.backend.clientCtx.Keyring)
-				tx, err := msg.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "aphoton")
+				tx, err := msg.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "azeta")
 				suite.Require().NoError(err)
 				txEncoder := suite.backend.clientCtx.TxConfig.TxEncoder()
 				txBytes, err := txEncoder(tx)
@@ -133,7 +133,7 @@ func (suite *BackendTestSuite) TestSendTransaction() {
 				ethSigner := ethtypes.LatestSigner(suite.backend.ChainConfig())
 				msg := callArgsDefault.ToTransaction()
 				msg.Sign(ethSigner, suite.backend.clientCtx.Keyring)
-				tx, err := msg.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "aphoton")
+				tx, err := msg.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "azeta")
 				suite.Require().NoError(err)
 				txEncoder := suite.backend.clientCtx.TxConfig.TxEncoder()
 				txBytes, err := txEncoder(tx)
@@ -246,7 +246,7 @@ func (suite *BackendTestSuite) TestSignTypedData() {
 			apitypes.TypedData{},
 			false,
 		},
-		// TODO: Generate a TypedData msg
+		// TODO (https://github.com/zeta-chain/node/issues/2302): Generate a TypedData msg
 	}
 
 	for _, tc := range testCases {

rpc/backend/tracing_test.go

@@ -40,14 +40,14 @@ func (suite *BackendTestSuite) TestTraceTransaction() {
 
 	msgEthereumTx.From = from.String()
 	msgEthereumTx.Sign(ethSigner, suite.signer)
-	tx, err := msgEthereumTx.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "aphoton")
+	tx, err := msgEthereumTx.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "azeta")
 	suite.Require().NoError(err)
 	txBz, err := txEncoder(tx)
 	suite.Require().NoError(err)
 
 	msgEthereumTx2.From = from.String()
 	msgEthereumTx2.Sign(ethSigner, suite.signer)
-	tx2, err := msgEthereumTx2.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "aphoton")
+	tx2, err := msgEthereumTx2.BuildTx(suite.backend.clientCtx.TxConfig.NewTxBuilder(), "azeta")
 	suite.Require().NoError(err)
 	txBz2, err := txEncoder(tx2)
 	suite.Require().NoError(err)

rpc/backend/utils_test.go

@@ -6,7 +6,7 @@ import (
 	"github.com/cometbft/cometbft/proto/tendermint/crypto"
 )
 
-func mookProofs(num int, withData bool) *crypto.ProofOps {
+func mockProofs(num int, withData bool) *crypto.ProofOps {
 	var proofOps *crypto.ProofOps
 	if num > 0 {
 		proofOps = new(crypto.ProofOps)
@@ -30,17 +30,17 @@ func (suite *BackendTestSuite) TestGetHexProofs() {
 	}{
 		{
 			"no proof provided",
-			mookProofs(0, false),
+			mockProofs(0, false),
 			defaultRes,
 		},
 		{
 			"no proof data provided",
-			mookProofs(1, false),
+			mockProofs(1, false),
 			defaultRes,
 		},
 		{
 			"valid proof provided",
-			mookProofs(1, true),
+			mockProofs(1, true),
 			[]string{"0x0a190a034b4559120556414c55451a0b0801180120012a03000202"},
 		},
 	}