PR comments

app/ante/vesting_test.go

@@ -94,7 +94,6 @@ func TestVesting_AnteHandle(t *testing.T) {
 			_, err = decorator.AnteHandle(ctx, tx, false, mmd.AnteHandle)
 
 			if tt.wantHasErr {
-				require.Error(t, err)
 				require.ErrorContains(t, err, tt.wantErr)
 			} else {
 				require.NoError(t, err)

pkg/crypto/pubkey_test.go

@@ -365,7 +365,7 @@ func TestGetEVMAddress(t *testing.T) {
 	t.Run("should error if non bech32", func(t *testing.T) {
 		pk := PubKey("invalid")
 		e, err := pk.GetEVMAddress()
-		require.Error(t, err)
+		require.ErrorContains(t, err, "decoding bech32 failed")
 		require.Equal(t, chains.NoAddress, e)
 	})
 }

x/crosschain/keeper/initiate_outbound.go

@@ -3,6 +3,7 @@ package keeper
 import (
 	"fmt"
 
+	cosmoserrors "cosmossdk.io/errors"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
 	"github.com/zeta-chain/zetacore/pkg/chains"
@@ -11,17 +12,27 @@ import (
 
 // InitiateOutbound initiates the outbound for the CCTX depending on the CCTX gateway.
 // It does a conditional dispatch to correct CCTX gateway based on the receiver chain
-// which handle the state changes and error handling.
+// which handles the state changes and error handling.
 func (k Keeper) InitiateOutbound(ctx sdk.Context, cctx *types.CrossChainTx) (types.CctxStatus, error) {
 	receiverChainID := cctx.GetCurrentOutboundParam().ReceiverChainId
 	chainInfo := chains.GetChainFromChainID(receiverChainID)
 	if chainInfo == nil {
-		return cctx.CctxStatus.Status, fmt.Errorf("chain info not found for %d", receiverChainID)
+		return cctx.CctxStatus.Status, cosmoserrors.Wrap(
+			types.ErrInitiatitingOutbound,
+			fmt.Sprintf(
+				"chain info not found for %d", receiverChainID,
+			),
+		)
 	}
 
 	cctxGateway, ok := k.cctxGateways[chainInfo.CctxGateway]
 	if !ok {
-		return cctx.CctxStatus.Status, fmt.Errorf("CCTXGateway not defined for receiver chain %d", receiverChainID)
+		return cctx.CctxStatus.Status, cosmoserrors.Wrap(
+			types.ErrInitiatitingOutbound,
+			fmt.Sprintf(
+				"CCTXGateway not defined for receiver chain %d", receiverChainID,
+			),
+		)
 	}
 
 	return cctxGateway.InitiateOutbound(ctx, cctx), nil

x/crosschain/keeper/msg_server_vote_inbound_tx.go

@@ -106,8 +106,8 @@ func (k msgServer) VoteInbound(
 	if err != nil {
 		return nil, err
 	}
-	// Inititiate outbound, the process function manages the state commit and cctx status change.
-	//	If the process fails, the changes to the evm state are rolled back.
+	// Initiate outbound, the process function manages the state commit and cctx status change.
+	// If the process fails, the changes to the evm state are rolled back.
 	_, err = k.InitiateOutbound(ctx, &cctx)
 	if err != nil {
 		return nil, err

x/crosschain/types/errors.go

@@ -48,4 +48,5 @@ var (
 	ErrUnableToDecodeMessageString   = errorsmod.Register(ModuleName, 1151, "unable to decode message string")
 	ErrInvalidRateLimiterFlags       = errorsmod.Register(ModuleName, 1152, "invalid rate limiter flags")
 	ErrMaxTxOutTrackerHashesReached  = errorsmod.Register(ModuleName, 1153, "max tx out tracker hashes reached")
+	ErrInitiatitingOutbound          = errorsmod.Register(ModuleName, 1154, "cannot initiate outbound")
 )

x/fungible/keeper/msg_server_deploy_system_contract_test.go

@@ -72,7 +72,6 @@ func TestMsgServer_DeploySystemContracts(t *testing.T) {
 		mockFailedContractDeployment(ctx, t, k)
 
 		_, err := msgServer.DeploySystemContracts(ctx, types.NewMsgDeploySystemContracts(admin))
-		require.Error(t, err)
 		require.ErrorContains(t, err, "failed to deploy")
 	})