Skip to content

Commit

Permalink
add changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
kingpinXD committed Aug 1, 2024
1 parent 8ffc978 commit 309358e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 10 deletions.
4 changes: 4 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

* [2578](https://github.com/zeta-chain/node/pull/2578) - Add Gateway address in protocol contract list

### Refactor

* [2615](https://github.com/zeta-chain/node/pull/2615) - Refactor cleanup of outbound trackers

## v19.0.0

### Breaking Changes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Broadcast message UpdateGatewayContract to update the gateway contract address

```
zetacored tx fungible update-gateway-contract [contract-address] [flags]
zetacored tx fungible update-gateway-contract [contract-address] [flags]
```

### Options
Expand Down
11 changes: 2 additions & 9 deletions x/crosschain/keeper/msg_server_vote_outbound_tx.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ func (k msgServer) VoteOutbound(
}

// Set the finalized ballot to the current outbound params.
// The two cases are possible
// 1. The outbound tx is successful, and this is the only ballot that is set
// 2. Revert TX is created, in which case the ballot for the revert TX would be set only when that ballot is finalized.
cctx.SetOutboundBallotIndex(ballotIndex)
// If ballot is successful, the value received should be the out tx amount.
err = cctx.AddOutbound(ctx, *msg, ballot.BallotStatus)
Expand Down Expand Up @@ -203,13 +200,9 @@ SaveOutbound saves the outbound transaction.It does the following things in one
func (k Keeper) SaveOutbound(ctx sdk.Context, cctx *types.CrossChainTx) {
// #nosec G115 always in range
for _, outboundParams := range cctx.OutboundParams {
k.GetObserverKeeper().RemoveFromPendingNonces(ctx, outboundParams.TssPubkey, outboundParams.ReceiverChainId, int64(outboundParams.TssNonce))
k.GetObserverKeeper().
RemoveFromPendingNonces(ctx, outboundParams.TssPubkey, outboundParams.ReceiverChainId, int64(outboundParams.TssNonce))
k.RemoveOutboundTrackerFromStore(ctx, outboundParams.ReceiverChainId, outboundParams.TssNonce)
ctx.Logger().With(
"voteOutboundID", voteOutboundID,
"trackerIndex", getOutboundTrackerIndex(outboundParams.ReceiverChainId, outboundParams.TssNonce),
"blockHeight", ctx.BlockHeight(),
).Info("Remove tracker")
}

// This should set nonce to cctx only if a new revert is created.
Expand Down

0 comments on commit 309358e

Please sign in to comment.