review feedback

Dockerfile-localnet

@@ -59,11 +59,12 @@ FROM base-runtime AS latest-runtime
 COPY --from=cosmovisor-build /go/bin/cosmovisor /usr/local/bin
 COPY --from=latest-build /go/bin/zetacored /go/bin/zetaclientd /go/bin/zetaclientd-supervisor /go/bin/zetae2e /usr/local/bin
 
-# optional old version build
+# optional old version build. This old build is used as the genesis version in the upgrade tests.
 # use --target latest-runtime to skip
 # 
 # TODO: just download binaries from github release now that we're using glibc
 # we can't do this right now since we do not have a v16 release candidate
+# https://github.com/zeta-chain/node/issues/2179
 FROM base-build as old-build
 
 ARG OLD_VERSION

contrib/localnet/docker-compose-upgrade.yml

@@ -24,28 +24,28 @@ services:
     entrypoint: ["/work/start-zetae2e.sh", "local", "upgrade"]
     image: orchestrator
 
-  upgradehost:
+  upgrade-host:
     image: zetanode:latest
-    container_name: upgradehost
-    hostname: upgradehost
-    entrypoint: ["/root/start-upgradehost.sh"]
+    container_name: upgrade-host
+    hostname: upgrade-host
+    entrypoint: ["/root/start-upgrade-host.sh"]
     networks:
       mynetwork:
         ipv4_address: 172.20.0.250
     volumes:
       - ssh:/root/.ssh
 
-  upgradeorchestrator:
+  upgrade-orchestrator:
     # must run from old node for api compatibility
     image: zetanode:old
-    container_name: upgradeorchestrator
-    hostname: upgradeorchestrator
-    entrypoint: ["/root/start-upgradeorchestrator.sh", "225"]
+    container_name: upgrade-orchestrator
+    hostname: upgrade-orchestrator
+    entrypoint: ["/root/start-upgrade-orchestrator.sh", "225"]
     networks:
       mynetwork:
         ipv4_address: 172.20.0.251
     depends_on:
       - zetacore0
-      - upgradehost
+      - upgrade-host
     volumes:
       - ssh:/root/.ssh