Skip to content

Commit

Permalink
resolve comments 2
Browse files Browse the repository at this point in the history
  • Loading branch information
kingpinXD committed Dec 13, 2024
1 parent fd1dec3 commit 2be31f2
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 27 deletions.
4 changes: 2 additions & 2 deletions simulation/simulation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ func TestAppImportExport(t *testing.T) {
// 1. It runs a full simulation and exports the state
// 2. It creates a new app, and db
// 3. It imports the exported state into the new app
// 4. It runs a simulation on the new app and verifies that there is error in the second simulation
// 4. It runs a simulation on the new app and verifies that there is no error in the second simulation
func TestAppSimulationAfterImport(t *testing.T) {
config := zetasimulation.NewConfigFromFlags()

Expand Down Expand Up @@ -587,5 +587,5 @@ func TestAppSimulationAfterImport(t *testing.T) {
config,
simApp.AppCodec(),
)
require.NoError(t, err)
require.NoError(t, simErr)
}
23 changes: 0 additions & 23 deletions x/crosschain/simulation/operations_test.go

This file was deleted.

2 changes: 1 addition & 1 deletion x/observer/keeper/msg_server_update_observer.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (k msgServer) UpdateObserver(
if lastBlockCount.Count != totalObserverCountCurrentBlock {
return nil, errorsmod.Wrapf(
types.ErrUpdateObserver,
"Observer count mismatch current block : %d , last block : %d",
"Observer count mismatch current block: %d , last block: %d",
totalObserverCountCurrentBlock,
lastBlockCount.Count,
)

Check warning on line 81 in x/observer/keeper/msg_server_update_observer.go

View check run for this annotation

Codecov / codecov/patch

x/observer/keeper/msg_server_update_observer.go#L76-L81

Added lines #L76 - L81 were not covered by tests
Expand Down
1 change: 0 additions & 1 deletion x/observer/keeper/tss.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ func (k Keeper) RemoveTSS(ctx sdk.Context) {
store.Delete([]byte{0})
}

// TODO define a type for a list of TSS isntead of using []types.TSS
// GetAllTSS returns all tss historical information from the store
func (k Keeper) GetAllTSS(ctx sdk.Context) (list []types.TSS) {
store := prefix.NewStore(ctx.KVStore(k.storeKey), types.KeyPrefix(types.TSSHistoryKey))
Expand Down

0 comments on commit 2be31f2

Please sign in to comment.