set back 1 unit approval

zeta-chain · Jul 23, 2024 · 281cf19 · 281cf19
1 parent 431d533
commit 281cf19
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/e2e/e2etests/test_eth_withdraw.go b/e2e/e2etests/test_eth_withdraw.go
@@ -17,11 +17,8 @@ func TestEtherWithdraw(r *runner.E2ERunner, args []string) {
 	withdrawalAmount, ok := new(big.Int).SetString(args[0], 10)
 	require.True(r, ok, "Invalid withdrawal amount specified for TestEtherWithdraw.")
 
-	// add one unit to the withdrawal amount to account for the approval because withdrawal fees are automatically deducted
-	approvalAmount := new(big.Int).Add(withdrawalAmount, big.NewInt(1e18))
-
-	// approve
-	tx, err := r.ETHZRC20.Approve(r.ZEVMAuth, r.ETHZRC20Addr, approvalAmount)
+	// approve 1 unit of the gas token to cover the gas fee transfer
+	tx, err := r.ETHZRC20.Approve(r.ZEVMAuth, r.ETHZRC20Addr, big.NewInt(1e18))
 	require.NoError(r, err)
 
 	r.Logger.EVMTransaction(*tx, "approve")

diff --git a/e2e/e2etests/test_eth_withdraw_restricted_address.go b/e2e/e2etests/test_eth_withdraw_restricted_address.go
@@ -18,12 +18,9 @@ func TestEtherWithdrawRestricted(r *runner.E2ERunner, args []string) {
 
 	withdrawalAmount, ok := new(big.Int).SetString(args[0], 10)
 	require.True(r, ok)
-
-	// add one unit to the withdrawal amount to account for the approval because withdrawal fees are automatically deducted
-	approvalAmount := new(big.Int).Add(withdrawalAmount, big.NewInt(1e18))
-
-	// approve
-	tx, err := r.ETHZRC20.Approve(r.ZEVMAuth, r.ETHZRC20Addr, approvalAmount)
+
+	// approve 1 unit of the gas token to cover the gas fee transfer
+	tx, err := r.ETHZRC20.Approve(r.ZEVMAuth, r.ETHZRC20Addr, big.NewInt(1e18))
 	require.NoError(r, err)
 
 	r.Logger.EVMTransaction(*tx, "approve")