Skip to content

feat: block header and merkle proof #831

feat: block header and merkle proof

feat: block header and merkle proof #831

Triggered via pull request September 14, 2023 08:17
Status Failure
Total duration 6m 29s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

sast-linters.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 4 warnings
lint: testutil/keeper/codec.go#L1
: # github.com/zeta-chain/zetacore/testutil/keeper
lint: testutil/keeper/crosschain.go#L87
cannot use crosschainmocks.NewCrosschainObserverKeeper(t) (value of type *"github.com/zeta-chain/zetacore/testutil/keeper/mocks/crosschain".CrosschainObserverKeeper) as type "github.com/zeta-chain/zetacore/x/crosschain/types".ZetaObserverKeeper in assignment:
lint: testutil/keeper/crosschain.go#L137
impossible type assertion: keeper.GetObserverKeeper().(*crosschainmocks.CrosschainObserverKeeper)
lint: common/ethereum/proof.go#L131
Error return value of `t.Prove` is not checked (errcheck)
lint: x/observer/keeper/msg_server_add_block_header.go#L34
ineffectual assignment to ballot (ineffassign)
lint: x/crosschain/keeper/keeper_out_tx_tracker.go#L206
ineffectual assignment to err (ineffassign)
lint
issues found
gosec: testutil/keeper/crosschain.go#L87
cannot use crosschainmocks.NewCrosschainObserverKeeper(t) (value of type *"github.com/zeta-chain/zetacore/testutil/keeper/mocks/crosschain".CrosschainObserverKeeper) as "github.com/zeta-chain/zetacore/x/crosschain/types".ZetaObserverKeeper value in assignment: *"github.com/zeta-chain/zetacore/testutil/keeper/mocks/crosschain".CrosschainObserverKeeper does not implement "github.com/zeta-chain/zetacore/x/crosschain/types".ZetaObserverKeeper (missing method GetBlockHeader)
gosec: testutil/keeper/crosschain.go#L137
impossible type assertion: keeper.GetObserverKeeper().(*crosschainmocks.CrosschainObserverKeeper)
gosec
Process completed with exit code 1.
git-guardian
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, chrisdickinson/setup-yq@latest. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint: x/observer/types/messages_add_block_header.go#L20
var-naming: func parameter chainId should be chainID (revive)
gosec
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/