Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --exit-on-error flag #41

Merged
merged 3 commits into from
Sep 30, 2024
Merged

feat: --exit-on-error flag #41

merged 3 commits into from
Sep 30, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Sep 30, 2024

  • --exit-on-error flag to kill localnet if revert fails or tx reverted without call on revert. This could be useful in CI, where you want localnet to fail if something goes wrong
  • refactored the stop task to remove localnet.pid if if exists, but the localnet is not running (it cannot cleanup after itself and delete pid if it's not running)

@fadeev fadeev marked this pull request as draft September 30, 2024 08:18
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fadeev fadeev changed the title fix: stop without throwing an error feat: exit on error flag Sep 30, 2024
@fadeev fadeev changed the title feat: exit on error flag feat: --exit-on-error flag Sep 30, 2024
@fadeev fadeev marked this pull request as ready for review September 30, 2024 13:49
@fadeev fadeev requested review from fbac and lumtis September 30, 2024 13:50
@fadeev
Copy link
Member Author

fadeev commented Sep 30, 2024

@lumtis @fbac sorry, PR was in draft mode, requesting review again. I've updated the description and pushed new changes.

@fadeev fadeev merged commit 764ec5b into main Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants