Fix: Solana Web3.js Library Supply Chain Attack #224
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces updates to the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (5)
examples/call/package.json(1 hunks)examples/hello/package.json(1 hunks)examples/nft/package.json(1 hunks)examples/swap/package.json(1 hunks)examples/token/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/swap/package.json
- examples/hello/package.json
🔇 Additional comments (1)
examples/call/package.json (1)
Line range hint 1-63: Verify dependency resolution across all example projects
To ensure consistent and secure dependency resolution across all example projects, we should verify that no project inadvertently pulls in the vulnerable versions through transitive dependencies.
✅ Verification successful
Dependency resolution check completed - No vulnerable versions detected
The analysis of yarn.lock files across all example projects shows that:
- All projects are using either version 1.95.2 or 1.95.3 of @solana/web3.js
- No instances of the vulnerable versions (1.95.6, 1.95.7) were found
- Dependencies are consistently resolved across all example projects
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any occurrence of vulnerable @solana/web3.js versions in yarn.lock files
echo "Checking for vulnerable @solana/web3.js versions (1.95.6, 1.95.7) in yarn.lock files..."
find . -name "yarn.lock" -type f -exec sh -c '
echo "\nChecking {}:"
grep -A 2 "@solana/web3.js@" {} || true
' \;
echo "\nChecking for any direct or indirect dependencies on @solana/web3.js..."
for pkg in $(find . -name "package.json"); do
echo "\nAnalyzing dependencies in $pkg:"
jq -r '.dependencies + .devDependencies | to_entries[] | select(.value | contains("@solana/web3.js")) | "\(.key): \(.value)"' "$pkg" 2>/dev/null || true
done
Length of output: 4427
examples/token/package.json
Outdated
| @@ -55,7 +55,7 @@ | |||
| "@coral-xyz/anchor": "0.30.0", | |||
| "@solana-developers/helpers": "^2.4.0", | |||
| "@solana/spl-memo": "^0.2.5", | |||
| "@solana/web3.js": "^1.95.2", | |||
| "@solana/web3.js": "^1.95.5", | |||
There was a problem hiding this comment.
Critical: Version constraint still allows vulnerable versions
The current update to "@solana/web3.js": "^1.95.5" does not effectively prevent the installation of the compromised versions (1.95.6 and 1.95.7). The caret (^) in the version constraint allows updates to all future patch versions, potentially exposing the project to the supply chain attack.
Apply this fix to explicitly prevent installation of vulnerable versions:
- "@solana/web3.js": "^1.95.5",
+ "@solana/web3.js": "~1.95.5",This change uses the tilde (~) operator to only allow patch updates within the 1.95.x range up to but not including 1.95.6, effectively blocking the compromised versions.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@solana/web3.js": "^1.95.5", | |
| "@solana/web3.js": "~1.95.5", |
examples/nft/package.json
Outdated
| @@ -55,7 +55,7 @@ | |||
| "@coral-xyz/anchor": "0.30.0", | |||
| "@solana-developers/helpers": "^2.4.0", | |||
| "@solana/spl-memo": "^0.2.5", | |||
| "@solana/web3.js": "^1.95.2", | |||
| "@solana/web3.js": "^1.95.5", | |||
There was a problem hiding this comment.
Critical: Version constraint still allows vulnerable versions
The current update to "@solana/web3.js": "^1.95.5" does not effectively prevent the installation of the compromised versions (1.95.6 and 1.95.7). The caret (^) in the version constraint allows updates to all future patch versions, potentially exposing the project to the supply chain attack.
Apply this fix to explicitly prevent installation of vulnerable versions:
- "@solana/web3.js": "^1.95.5",
+ "@solana/web3.js": "~1.95.5",This change uses the tilde (~) operator to only allow patch updates within the 1.95.x range up to but not including 1.95.6, effectively blocking the compromised versions.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@solana/web3.js": "^1.95.5", | |
| "@solana/web3.js": "~1.95.5", |
examples/call/package.json
Outdated
| @@ -56,7 +56,7 @@ | |||
| "@coral-xyz/anchor": "0.30.0", | |||
| "@solana-developers/helpers": "^2.4.0", | |||
| "@solana/spl-memo": "^0.2.5", | |||
| "@solana/web3.js": "^1.95.2", | |||
| "@solana/web3.js": "^1.95.5", | |||
There was a problem hiding this comment.
Critical: Version constraint still allows vulnerable versions
The current update to "@solana/web3.js": "^1.95.5" does not effectively prevent the installation of the compromised versions (1.95.6 and 1.95.7). The caret (^) in the version constraint allows updates to all future patch versions, potentially exposing the project to the supply chain attack.
Apply this fix to explicitly prevent installation of vulnerable versions:
- "@solana/web3.js": "^1.95.5",
+ "@solana/web3.js": "~1.95.5",This change uses the tilde (~) operator to only allow patch updates within the 1.95.x range up to but not including 1.95.6, effectively blocking the compromised versions.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@solana/web3.js": "^1.95.5", | |
| "@solana/web3.js": "~1.95.5", |
Fix: Solana Web3.js Library Supply Chain Attack
A recent supply chain attack compromised versions 1.95.6 and 1.95.7 of the @solana/web3.js JavaScript library, leading to the theft of approximately $160,000 in assets. The malicious code exfiltrated private keys, affecting developers and applications that integrated these versions.
References:
Solana Web3.js Library Compromised in Targeted Supply Chain Attack
Supply Chain Attack Detected in Solana's web3.js Library
Summary by CodeRabbit
New Features
@solana/web3.jsdependency version to improve performance and stability across multiple example projects.Bug Fixes
@solana/web3.jsfrom^1.95.2to^1.95.8, potentially addressing minor issues.