onCall: remove return

zeta-chain · Nov 12, 2024 · c5e2348 · c5e2348
1 parent 68217a5
commit c5e2348
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/examples/call/contracts/Connected.sol b/examples/call/contracts/Connected.sol
@@ -53,10 +53,8 @@ contract Connected {
     function onCall(
         MessageContext calldata context,
         bytes calldata message
-    ) external payable onlyGateway returns (bytes4) {
+    ) external payable onlyGateway {
         emit HelloEvent("Hello on EVM from onCall()", "hey");
-
-        return "";
     }
 
     function onRevert(

diff --git a/examples/nft/contracts/Connected.sol b/examples/nft/contracts/Connected.sol
@@ -91,7 +91,7 @@ contract Connected is
     function onCall(
         MessageContext calldata context,
         bytes calldata message
-    ) external payable onlyGateway returns (bytes4) {
+    ) external payable onlyGateway {
         if (context.sender != counterparty) revert Unauthorized();
 
         (address receiver, uint256 tokenId, string memory uri) = abi.decode(
@@ -102,7 +102,6 @@ contract Connected is
         _safeMint(receiver, tokenId);
         _setTokenURI(tokenId, uri);
         emit TokenTransferReceived(receiver, tokenId, uri);
-        return "";
     }
 
     function onRevert(RevertContext calldata context) external onlyGateway {

diff --git a/examples/token/contracts/Connected.sol b/examples/token/contracts/Connected.sol
@@ -70,15 +70,14 @@ contract Connected is ERC20, Ownable2Step, Events {
     function onCall(
         MessageContext calldata context,
         bytes calldata message
-    ) external payable onlyGateway returns (bytes4) {
+    ) external payable onlyGateway {
         if (context.sender != counterparty) revert Unauthorized();
         (address receiver, uint256 amount) = abi.decode(
             message,
             (address, uint256)
         );
         _mint(receiver, amount);
         emit TokenTransferReceived(receiver, amount);
-        return "";
     }
 
     function onRevert(RevertContext calldata context) external onlyGateway {}