switch to approve

zeta-chain · Oct 7, 2024 · b6a8ca3 · b6a8ca3
1 parent ded9f42
commit b6a8ca3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/examples/hello/contracts/Hello.sol b/examples/hello/contracts/Hello.sol
@@ -38,6 +38,7 @@ contract Hello is UniversalContract {
         RevertOptions memory revertOptions
     ) external {
         (, uint256 gasFee) = IZRC20(zrc20).withdrawGasFeeWithGasLimit(gasLimit);
+        IZRC20(zrc20).transferFrom(msg.sender, address(this), gasFee);
         IZRC20(zrc20).approve(address(gateway), gasFee);
         gateway.call(receiver, zrc20, message, gasLimit, revertOptions);
     }
@@ -52,10 +53,11 @@ contract Hello is UniversalContract {
     ) external {
         (address gasZRC20, uint256 gasFee) = IZRC20(zrc20)
             .withdrawGasFeeWithGasLimit(gasLimit);
-        if (zrc20 == gasZRC20) {
-            IZRC20(zrc20).approve(address(gateway), amount + gasFee);
-        } else {
-            IZRC20(zrc20).approve(address(gateway), amount);
+        uint256 total = zrc20 == gasZRC20 ? amount + gasFee : amount;
+        IZRC20(zrc20).transferFrom(msg.sender, address(this), total);
+        IZRC20(zrc20).approve(address(gateway), total);
+        if (zrc20 != gasZRC20) {
+            IZRC20(gasZRC20).transferFrom(msg.sender, address(this), gasFee);
             IZRC20(gasZRC20).approve(address(gateway), gasFee);
         }
         gateway.withdrawAndCall(

diff --git a/examples/hello/tasks/helloCall.ts b/examples/hello/tasks/helloCall.ts
@@ -58,11 +58,7 @@ const main = async (args: any, hre: HardhatRuntimeEnvironment) => {
   const gasLimit = hre.ethers.BigNumber.from(args.txOptionsGasLimit);
   const zrc20 = new ethers.Contract(args.zrc20, ZRC20ABI.abi, signer);
   const [, gasFee] = await zrc20.withdrawGasFeeWithGasLimit(gasLimit);
-  const zrc20TransferTx = await zrc20.transfer(
-    args.contract,
-    gasFee,
-    txOptions
-  );
+  const zrc20TransferTx = await zrc20.approve(args.contract, gasFee, txOptions);
 
   await zrc20TransferTx.wait();
 

diff --git a/examples/hello/tasks/helloWithdrawAndCall.ts b/examples/hello/tasks/helloWithdrawAndCall.ts
@@ -62,20 +62,20 @@ const main = async (args: any, hre: HardhatRuntimeEnvironment) => {
   const zrc20 = new ethers.Contract(args.zrc20, ZRC20ABI.abi, signer);
   const [gasZRC20, gasFee] = await zrc20.withdrawGasFeeWithGasLimit(gasLimit);
   const gasZRC20Contract = new ethers.Contract(gasZRC20, ZRC20ABI.abi, signer);
-  const gasFeeTransfer = await gasZRC20Contract.transfer(
+  const gasFeeApprove = await gasZRC20Contract.approve(
     args.contract,
     gasZRC20 == args.zrc20 ? gasFee.add(amount) : gasFee,
     txOptions
   );
-  await gasFeeTransfer.wait();
+  await gasFeeApprove.wait();
 
   if (gasZRC20 !== args.zrc20) {
-    const targetTokenTransfer = await zrc20.transfer(
+    const targetTokenApprove = await zrc20.approve(
       args.contract,
       gasFee.add(amount),
       txOptions
     );
-    await targetTokenTransfer.wait();
+    await targetTokenApprove.wait();
   }
 
   const factory = (await hre.ethers.getContractFactory(args.name)) as any;