update test

zeta-chain · Feb 6, 2024 · 6bedfc1 · 6bedfc1
1 parent c320f5a
commit 6bedfc1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 16 deletions.
diff --git a/packages/zeta-app-contracts/contracts/multi-chain-value/MultiChainValue.sol b/packages/zeta-app-contracts/contracts/multi-chain-value/MultiChainValue.sol
@@ -102,12 +102,6 @@ contract MultiChainValue is ZetaInteractor, MultiChainValueErrors {
     }
 
     function onZetaRevert(ZetaInterfaces.ZetaRevert calldata zetaRevert) external isValidRevertCall(zetaRevert) {
-        bool success1 = ZetaEth(zetaToken).approve(address(this), zetaRevert.remainingZetaValue);
-        bool success2 = ZetaEth(zetaToken).transferFrom(
-            address(this),
-            zetaRevert.zetaTxSenderAddress,
-            zetaRevert.remainingZetaValue
-        );
-        if (!(success1 && success2)) revert ErrorTransferringZeta();
+        //@dev this version do not handle revert
     }
 }
diff --git a/packages/zeta-app-contracts/test/MultiChainValue.spec.ts b/packages/zeta-app-contracts/test/MultiChainValue.spec.ts
@@ -78,14 +78,7 @@ describe("MultiChainValue tests", () => {
 
       await expect(tx)
         .to.be.emit(zetaConnectorMockContract, "Send")
-        .withArgs(
-          chainBId,
-          account1Address.toLowerCase(),
-          300000,
-          defaultAbiCoder.encode(["address"], [deployer.address]),
-          10,
-          defaultAbiCoder.encode(["string"], [""])
-        );
+        .withArgs(chainBId, account1Address.toLowerCase(), 300000, "0x", 10, defaultAbiCoder.encode(["string"], [""]));
     });
 
     it("Should send native token", async () => {
@@ -138,7 +131,7 @@ describe("MultiChainValue tests", () => {
         ethers.utils.hexZeroPad("0x0", 32)
       );
 
-      const balance = await zetaEthMockContract.balanceOf(account1.address);
+      const balance = await zetaEthMockContract.balanceOf(multiChainValueContractA.address);
       await expect(balance).to.be.eq(remainingZetaValue);
     });